DX-1846: Bump HTMLProofer from v3 to v4

Author: asbjornu

.docker/entrypoint/Gemfile

@@ -14,8 +14,8 @@ gem 'rouge', '~> 3'
 group :development, :test do
   gem 'codecov', '>= 0.6'
   gem 'diffy', '~> 3'
-  gem 'html-proofer', '~> 3'
-  gem 'html-proofer-unrendered-markdown', '>= 0.1'
+  gem 'html-proofer', '>= 4'
+  gem 'html-proofer-unrendered-markdown', '>= 0.2'
   gem 'its', '>= 0.2'
   gem 'rake', '~> 13'
   gem 'rspec', '~> 3'

.docker/entrypoint/lib/commands/verifier.rb

@@ -68,14 +68,15 @@ def options(ignore_urls = nil)
           log_level = @context.arguments.log_level
           opts[:log_level] = log_level.to_sym unless log_level.nil?
           opts[:url_ignore] = ignore_urls if ignore_urls.valid_array?
-          opts[:cache] = { timeframe: '1h' }
+          opts[:cache] = { timeframe: { external: '1w' } }
 
           opts
         end
 
         def default_options
           {
-            assume_extension: true,
+            checks: ['Links', 'Images', 'Scripts', 'UnrenderedLink'],
+            allow_missing_href: true,
             check_html: true,
             enforce_https: true,
             only_4xx: true,

.docker/entrypoint/spec/verifier_spec.rb

@@ -78,7 +78,8 @@
 
     it 'receives expected options' do
       expected_options = {
-        assume_extension: true,
+        checks: ['Links', 'Images', 'Scripts', 'UnrenderedLink'],
+        allow_missing_href: true,
         check_html: true,
         check_unrendered_link: true,
         enforce_https: true,
@@ -88,7 +89,7 @@
         typheous: {
           verbose: false
         },
-        cache: { :timeframe => '1h' }
+        cache: { timeframe: { external: '1w' } }
       }
       html_proofer_class = SpecHTMLProofer
       html_proofer = html_proofer_class.new

tests/minimal/index.md

@@ -10,11 +10,9 @@ Text can be **bold**, _italic_, or ~~strikethrough~~.
 * [Absolute URL to page]({{ page.url | absolute_url }}).
 * [Relative URL to page]({{ "/" | relative_url }}).
 * [External absolute full link](https://www.wikipedia.org)
-* [External protocol relative link](//www.wikipedia.org)
 * [Internal absolute full link]({{ site.url }})
-* [Internal explicit relative link](./page1)
-* [Internal implicit relative link](page1)
-* [Internal absolute link](/page1)
+* [Internal explicit relative link](./)
+* [Internal absolute link](/)
 
 There should be whitespace between paragraphs.