DX-1846: Bump HTMLProofer from v3 to v4 #298
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 28 28
Lines 784 784
=======================================
Hits 742 742
Misses 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove references to `swedbank-pay-design-guide-jekyll-theme` to break the circular dependency between the two codebases.
asbjornu
force-pushed
the
feature/dx-1846_htmlproofer_bump
branch
from
f934d69 to
f2765d2
Compare
Disable debug to avoid HTMLProofer loading awesome_print, because it leads to the following failure: ``` Traceback (most recent call last): 10: from /var/jekyll/entrypoint/lib/entrypoint.rb:3:in `<main>' 9: from /var/jekyll/entrypoint/lib/entrypoint.rb:3:in `require_relative' 8: from /var/jekyll/entrypoint/lib/commander.rb:7:in `<top (required)>' 7: from /var/jekyll/entrypoint/lib/commander.rb:7:in `require_relative' 6: from /var/jekyll/entrypoint/lib/commands/verifier.rb:4:in `<top (required)>' 5: from /var/jekyll/entrypoint/lib/commands/verifier.rb:4:in `require' 4: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html-proofer.rb:3:in `<top (required)>' 3: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html-proofer.rb:3:in `require_relative' 2: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html_proofer.rb:18:in `<top (required)>' 1: from /usr/gem/ruby/2.7.0/gems/zeitwerk-2.6.0/lib/zeitwerk/kernel.rb:35:in `require' ``` https://github.com/SwedbankPay/jekyll-plantuml-docker/actions/runs/3079379097/jobs/4975588911#step:5:2106
- Fix the RuboCop error: lib/commands/verifier.rb:78:21: C: [Corrected] Style/WordArray: Use %w or %W for an array of words. - Add rubocop-rake and rubocop-rspec to rubocop config.
See 60ca6c7 for an explanation.
asbjornu
force-pushed
the
feature/dx-1846_htmlproofer_bump
branch
3 times, most recently
from
54c538e to
76f5404
Compare
asbjornu
force-pushed
the
feature/dx-1846_htmlproofer_bump
branch
from
76f5404 to
966a308
Compare
asbjornu
force-pushed
the
feature/dx-1846_htmlproofer_bump
branch
2 times, most recently
from
6363097 to
09eadcc
Compare
asbjornu
force-pushed
the
feature/dx-1846_htmlproofer_bump
branch
from
09eadcc to
05b365a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DX-1846: Bump HTMLProofer from v3 to v4 and html-proofer-unrendered-markdown from v0.1 to v0.2.