Merge pull request #205 from SwiftFiddle/refactor

Refactor

Author: kishikawakatsumi

Public/js/tree_view.js

@@ -44,8 +44,10 @@ export class TreeView {
 
     const li = document.createElement("li");
     li.classList.add("entry");
+
+    const element = document.createElement("div");
+
     if (this.hasChildren(node.id)) {
-      const element = document.createElement("div");
       const caret = downCaret.cloneNode(true);
       element.appendChild(caret);
 
@@ -70,48 +72,30 @@ export class TreeView {
           this.collapse(node, element, li);
         }
       });
-
-      li.addEventListener("mouseover", (event) => {
-        event.preventDefault();
-        event.stopPropagation();
-
-        li.classList.add("hover");
-        this.hoveredElement = li;
-        this.onmouseover(event, element, node);
-      });
-      li.addEventListener("mouseout", (event) => {
-        event.preventDefault();
-        event.stopPropagation();
-
-        li.classList.remove("hover");
-        this.onmouseout(event, element, node);
-      });
     } else {
-      const element = document.createElement("div");
       element.classList.add("token");
       if (node.text.length === 0) {
         element.innerHTML = `<span class="badge">Empty</span>`;
       } else {
         element.innerHTML = node.text;
       }
       li.appendChild(element);
+    }
 
-      li.addEventListener("mouseover", (event) => {
-        event.preventDefault();
-        event.stopPropagation();
+    li.addEventListener("mouseover", (event) => {
+      event.preventDefault();
+      event.stopPropagation();
 
-        li.classList.add("hover");
-        this.hoveredElement = li;
-        this.onmouseover(event, element, node);
-      });
-      li.addEventListener("mouseout", (event) => {
-        event.preventDefault();
-        event.stopPropagation();
+      li.classList.add("hover");
+      this.onmouseover(event, element, node);
+    });
+    li.addEventListener("mouseout", (event) => {
+      event.preventDefault();
+      event.stopPropagation();
 
-        li.classList.remove("hover");
-        this.onmouseout(event, element, node);
-      });
-    }
+      li.classList.remove("hover");
+      this.onmouseout(event, element, node);
+    });
 
     ul.appendChild(li);
     return ul;