Skip to content

Commit 670baf8

Browse files
Refactor
1 parent fba0d3f commit 670baf8

File tree

3 files changed

+29
-27
lines changed

3 files changed

+29
-27
lines changed

Public/css/popover.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
.popover-content dt {
4141
padding: 0 8px;
42-
background-color: #f2f2f2;
42+
background-color: #f5f5f5;
4343
font-family: Menlo, Consolas, "DejaVu Sans Mono", "Ubuntu Mono", monospace;
4444
}
4545

Public/js/structure_view.js

Lines changed: 28 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -64,31 +64,9 @@ function makeSyntaxPopoverContent(data) {
6464
const title = document.createElement("div");
6565
title.classList.add("title");
6666
title.innerText = `${data.text}Syntax`;
67-
container.appendChild(title);
67+
title.appendChild(makeSyntaxTypeBadge(data.type));
6868

69-
const label = document.createElement("span");
70-
label.classList.add("badge", "text-bg-light");
71-
switch (data.type) {
72-
case "decl": {
73-
label.innerText = "DeclSyntax";
74-
break;
75-
}
76-
case "expr": {
77-
label.innerText = "ExprSyntax";
78-
break;
79-
}
80-
case "pattern": {
81-
label.innerText = "PatternSyntax";
82-
break;
83-
}
84-
case "type": {
85-
label.innerText = "TypeSyntax";
86-
break;
87-
}
88-
default:
89-
break;
90-
}
91-
title.appendChild(label);
69+
container.appendChild(title);
9270

9371
const dl = document.createElement("dl");
9472

@@ -165,6 +143,32 @@ function makeDescriptionList(term, details, list) {
165143
list.appendChild(dd);
166144
}
167145

146+
function makeSyntaxTypeBadge(type) {
147+
const badge = document.createElement("span");
148+
badge.classList.add("badge", "text-bg-light");
149+
switch (type) {
150+
case "decl": {
151+
badge.innerText = "DeclSyntax";
152+
break;
153+
}
154+
case "expr": {
155+
badge.innerText = "ExprSyntax";
156+
break;
157+
}
158+
case "pattern": {
159+
badge.innerText = "PatternSyntax";
160+
break;
161+
}
162+
case "type": {
163+
badge.innerText = "TypeSyntax";
164+
break;
165+
}
166+
default:
167+
break;
168+
}
169+
return badge;
170+
}
171+
168172
function stripHTMLTag(text) {
169173
const div = document.createElement("div");
170174
div.innerHTML = text

Public/js/tree_view.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,6 @@ export class TreeView {
160160
}
161161
}
162162

163-
function onMouseover(event, target, parent) {}
164-
165163
function makeDownCaret() {
166164
const caret = document.createElement("span");
167165
caret.classList.add(

0 commit comments

Comments
 (0)