Merge pull request #209 from SwiftFiddle/throttle-remove

Remove throttle

Author: kishikawakatsumi

Public/js/popover.js

@@ -1,7 +1,6 @@
 "use strict";
 
 import "../css/popover.css";
-import { throttle } from "./throttle.js";
 
 export class Popover {
   set maxWidth(value) {
@@ -29,26 +28,19 @@ export class Popover {
     this.popover.appendChild(this.popoverContent);
     document.body.appendChild(this.popover);
 
-    const onmouseover = throttle((event) => {
-      this.onmouseover(event);
-    });
-    const onmouseout = throttle((event) => {
-      this.onmouseout(event);
-    });
-
     this.popover.addEventListener(
       "mouseenter",
       (event) => {
         event.stopPropagation();
-        onmouseover(event);
+        this.onmouseover(event);
       },
       { capture: false, once: false, passive: false }
     );
     this.popover.addEventListener(
       "mouseleave",
       (event) => {
         event.stopPropagation();
-        onmouseout(event);
+        this.onmouseout(event);
       },
       { capture: false, once: false, passive: false }
     );

Public/js/statistics_view.js

@@ -5,8 +5,6 @@ import "datatables.net-bs5/css/dataTables.bootstrap5.min.css";
 
 import "../css/table.css";
 
-import { throttle } from "./throttle.js";
-
 export class StatisticsView {
   set error(error) {
     this.container.innerHTML = `<div class="alert alert-danger m-3" role="alert">${error}</div>`;
@@ -38,26 +36,19 @@ export class StatisticsView {
       tr.innerHTML = `<td style="font-family: Menlo, Consolas, 'DejaVu Sans Mono', 'Ubuntu Mono', monospace;">${row.text}</td><td><div>${row.ranges.length}</div></td>`;
       body.appendChild(tr);
 
-      const onmouseover = throttle((event, element, data) => {
-        this.onmouseover(event, element, data);
-      });
-      const onmouseout = throttle((event, element, data) => {
-        this.onmouseout(event, element, data);
-      });
-
       tr.addEventListener(
         "mouseover",
         (event) => {
           event.stopPropagation();
-          onmouseover(event, tr, row.ranges);
+          this.onmouseover(event, tr, row.ranges);
         },
         { capture: false, once: false, passive: false }
       );
       tr.addEventListener(
         "mouseout",
         (event) => {
           event.stopPropagation();
-          onmouseout(event, tr);
+          this.onmouseout(event, tr);
         },
         { capture: false, once: false, passive: false }
       );

Public/js/throttle.js

@@ -1,7 +1,6 @@
 "use strict";
 
 import "../css/tree_view.css";
-import { throttle } from "./throttle.js";
 
 const downCaret = makeDownCaret();
 const rightCaret = makeRightCaret();
@@ -83,20 +82,13 @@ export class TreeView {
       li.appendChild(element);
     }
 
-    const onmouseover = throttle((event, element, data) => {
-      this.onmouseover(event, element, data);
-    });
-    const onmouseout = throttle((event, element, data) => {
-      this.onmouseout(event, element, data);
-    });
-
     li.addEventListener(
       "mouseover",
       (event) => {
         event.stopPropagation();
 
         li.classList.add("hover");
-        onmouseover(event, element, node);
+        this.onmouseover(event, element, node);
       },
       { capture: false, once: false, passive: false }
     );
@@ -106,7 +98,7 @@ export class TreeView {
         event.stopPropagation();
 
         li.classList.remove("hover");
-        onmouseout(event, element, node);
+        this.onmouseout(event, element, node);
       },
       { capture: false, once: false, passive: false }
     );