Drop [FluentKit.Model] save overload, convert to a/a

Author: finestructure

Sources/App/Commands/Common.swift

@@ -19,8 +19,6 @@ import Vapor
 
 /// Update packages (in the `[Result<Joined<Package, Repository>, Error>]` array).
 ///
-/// Unlike the overload with a result parameter `Result<(Joined<Package, Repository>, [Version])` this will not use `Version` information to update the package.
-///
 /// - Parameters:
 ///   - client: `Client` object
 ///   - database: `Database` object

Sources/App/Core/Extensions/Model+ext.swift

@@ -16,12 +16,6 @@ import Fluent
 
 
 extension Array where Element: FluentKit.Model {
-    public func save(on database: Database) -> EventLoopFuture<Void> {
-        map {
-            $0.save(on: database)
-        }.flatten(on: database.eventLoop)
-    }
-
     public func save(on database: Database) async throws -> Void {
         for element in self {
             try await element.save(on: database)

Tests/AppTests/IngestorTests.swift

@@ -265,7 +265,7 @@ class IngestorTests: AppTestCase {
             Package(id: UUID(), url: "https://github.com/foo/1", status: .ok, processingStage: .reconciliation),
             Package(id: UUID(), url: "https://github.com/foo/2", status: .new, processingStage: .reconciliation)
         ]
-        try await pkgs.save(on: app.db).get()
+        try await pkgs.save(on: app.db)
         let results: [Result<Joined<Package, Repository>, Error>] = [ .success(.init(model: pkgs[0])),
                                                                       .success(.init(model: pkgs[1]))]
 

Tests/AppTests/PackageTests.swift

@@ -242,18 +242,18 @@ final class PackageTests: AppTestCase {
         )
     }
 
-    func test_findSignificantReleases_old_beta() throws {
+    func test_findSignificantReleases_old_beta() async throws {
         // Test to ensure outdated betas aren't picked up as latest versions
         // setup
         let pkg = Package(id: UUID(), url: "1")
-        try pkg.save(on: app.db).wait()
-        try Repository(package: pkg, defaultBranch: "main").save(on: app.db).wait()
+        try await pkg.save(on: app.db)
+        try await Repository(package: pkg, defaultBranch: "main").save(on: app.db)
         let versions = [
             try Version(package: pkg, packageName: "foo", reference: .branch("main")),
             try Version(package: pkg, packageName: "foo", reference: .tag(2, 0, 0)),
             try Version(package: pkg, packageName: "foo", reference: .tag(2, 0, 0, "rc1"))
         ]
-        try versions.save(on: app.db).wait()
+        try await versions.save(on: app.db)
 
         // MUT
         let (release, preRelease, defaultBranch) = Package.findSignificantReleases(versions: versions, branch: "main")