Handle ManifestErrors

Author: finestructure

Sources/App/Controllers/ValidateSPIManifestController.swift

@@ -38,8 +38,10 @@ enum ValidateSPIManifestController {
     static func validationResult(manifest: String) -> ValidateSPIManifest.ValidationResult {
         do {
             return .valid(try SPIManifest.Manifest.load(data: Data(manifest.utf8)))
-        } catch let error as DecodingError {
-            return .invalid("\(error)")
+        } catch let ManifestError.decodingError(error) {
+            return .invalid("Decoding failed: \(error)")
+        } catch let ManifestError.fileTooLarge(size: size) {
+            return .invalid("File must not exceed \(SPIManifest.Manifest.maxByteSize) bytes. File size: \(size) bytes.")
         } catch {
             return .invalid(error.localizedDescription)
         }

Tests/AppTests/ValidateSPIManifestControllerTests.swift

@@ -40,7 +40,7 @@ final class ValidateSPIManifestControllerTests: XCTestCase {
         let res = ValidateSPIManifestController.validationResult(manifest: yml)
 
         // validate
-        XCTAssertEqual(res.isValid, false)
+        XCTAssertEqual(res, .invalid("Decoding failed: Key not found: 'version'."))
     }
 
     func test_validationResult_tooLarge() throws {
@@ -58,6 +58,7 @@ final class ValidateSPIManifestControllerTests: XCTestCase {
 
         // validate
         XCTAssertEqual(res.isValid, false)
+        XCTAssertEqual(res, .invalid("File must not exceed \(SPIManifest.Manifest.maxByteSize) bytes. File size: \(yml.count) bytes."))
     }
 
 }