Update the collection if details have changed

Author: finestructure

Sources/App/Models/CustomCollection.swift

@@ -83,6 +83,11 @@ extension CustomCollection {
         if let collection = try await CustomCollection.query(on: database)
             .filter(\.$key == details.key)
             .first() {
+            if collection.details != details {
+                // Update the collection if any of the details have changed
+                collection.details = details
+                try await collection.update(on: database)
+            }
             return collection
         } else {
             let collection = CustomCollection(details)
@@ -106,7 +111,20 @@ extension CustomCollection {
     }
 
     var details: Details {
-        .init(key: key, name: name, description: description, badge: badge, url: url)
+        get {
+            .init(key: key,
+                  name: name,
+                  description: description,
+                  badge: badge,
+                  url: url)
+        }
+        set {
+            key = newValue.key
+            name = newValue.name
+            description = newValue.description
+            badge = newValue.badge
+            url = newValue.url
+        }
     }
 }
 

Tests/AppTests/CustomCollectionTests.swift

@@ -107,6 +107,23 @@ class CustomCollectionTests: AppTestCase {
             XCTAssertEqual(c.first?.name, "List")
             XCTAssertEqual(c.first?.url, "url")
         }
+
+        do { // a record is updated if data has changed
+             // MUT
+             let res = try await CustomCollection.findOrCreate(on: app.db, .init(key: "list",
+                                                                                 name: "New name",
+                                                                                 url: "new-url"))
+            // validate
+            XCTAssertEqual(res.key, "list")
+            XCTAssertEqual(res.name, "New name")
+            XCTAssertEqual(res.url, "new-url")
+
+            let c = try await CustomCollection.query(on: app.db).all()
+            XCTAssertEqual(c.count, 1)
+            XCTAssertEqual(c.first?.key, "list")
+            XCTAssertEqual(c.first?.name, "New name")
+            XCTAssertEqual(c.first?.url, "new-url")
+        }
     }
 
     func test_CustomCollectionPackage_attach() async throws {