Make init throws again and drop error handling

Author: finestructure

Sources/App/Controllers/BlogController.swift

@@ -18,11 +18,11 @@ import Plot
 enum BlogController {
 
     static func index(req: Request) async throws -> HTML {
-        BlogActions.Index.View(path: req.url.path, model: BlogActions.Model()).document()
+        BlogActions.Index.View(path: req.url.path, model: try BlogActions.Model()).document()
     }
 
     static func indexFeed(req: Request) async throws -> RSS {
-        let model = BlogActions.Model()
+        let model = try BlogActions.Model()
         let items = model.summaries.map { summary -> Node <RSS.ChannelContext> in
                 .item(
                     .guid(
@@ -58,7 +58,7 @@ enum BlogController {
         guard let slug = req.parameters.get("slug")
         else { throw Abort(.notFound) }
 
-        let model = BlogActions.Model()
+        let model = try BlogActions.Model()
         if let summary = model.summaries.first(where: { $0.slug == slug }) {
             return BlogActions.Show.View(path: req.url.path,
                                          model: summary).document()

Sources/App/Views/Blog/BlogActions+Model.swift

@@ -35,20 +35,15 @@ enum BlogActions {
 
         var summaries: [PostSummary]
 
-        init() {
-            do {
-                let allSummaries = try Self.allSummaries()
-
-                summaries = if Current.environment() == .production {
-                    // Only "published" posts show in production.
-                    allSummaries.filter { $0.published }
-                } else {
-                    // Show *everything* in development and on staging.
-                    allSummaries
-                }
-            } catch {
-                Current.logger().report(error: error)
-                summaries = []
+        init() throws {
+            let allSummaries = try Self.allSummaries()
+
+            summaries = if Current.environment() == .production {
+                // Only "published" posts show in production.
+                allSummaries.filter { $0.published }
+            } else {
+                // Show *everything* in development and on staging.
+                allSummaries
             }
         }
 

Tests/AppTests/BlogActionsModelTests.swift

@@ -38,7 +38,7 @@ class BlogActionsModelTests: AppTestCase {
             Current.environment = { .development }
 
             // MUT
-            let summaries = BlogActions.Model().summaries
+            let summaries = try BlogActions.Model().summaries
 
             XCTAssertEqual(summaries.count, 2)
             XCTAssertEqual(summaries.map(\.slug), ["post-2", "post-1"])
@@ -59,7 +59,7 @@ class BlogActionsModelTests: AppTestCase {
             Current.environment = { .production }
 
             // MUT
-            let summaries = BlogActions.Model().summaries
+            let summaries = try BlogActions.Model().summaries
 
             // validate
             XCTAssertEqual(summaries.map(\.slug), ["post-1"])