Fix warning, tidy up test

Author: finestructure

Sources/App/Commands/Ingest.swift

@@ -125,7 +125,7 @@ func ingest(client: Client,
                         s3Readme = .error("\(error)")
                     }
 
-                    let fork: Fork? = try? await getFork(on: database, parent: metadata.repository?.parent)
+                    let fork = await getFork(on: database, parent: metadata.repository?.parent)
 
                     try await updateRepository(on: database,
                                                for: repo,

Tests/AppTests/IngestorTests.swift

@@ -604,31 +604,24 @@ class IngestorTests: AppTestCase {
         try await Package(id: .id0, url: "https://github.com/foo/parent.git".url, processingStage: .analysis).save(on: app.db)
         try await Package(url: "https://github.com/bar/forked.git", processingStage: .analysis).save(on: app.db)
 
-        var parent: Github.Metadata.Parent?
-        
         // test lookup when package is in the index
-        parent = .init(url: "https://github.com/foo/parent.git")
-        let fork = await getFork(on: app.db, parent: parent)
+        let fork = await getFork(on: app.db, parent: .init(url: "https://github.com/foo/parent.git"))
         XCTAssertEqual(fork, .parentId(.id0))
 
         // test lookup when package is in the index but with different case in URL
-        parent = .init(url: "https://github.com/Foo/Parent.git")
-        let fork2 = await getFork(on: app.db, parent: parent)
+        let fork2 = await getFork(on: app.db, parent: .init(url: "https://github.com/Foo/Parent.git"))
         XCTAssertEqual(fork2, .parentId(.id0))
 
         // test whem metadata repo url doesn't have `.git` at end
-        parent = .init(url: "https://github.com/Foo/Parent")
-        let fork3 = await getFork(on: app.db, parent: parent)
+        let fork3 = await getFork(on: app.db, parent: .init(url: "https://github.com/Foo/Parent"))
         XCTAssertEqual(fork3, .parentId(.id0))
 
         // test lookup when package is not in the index
-        parent = .init(url: "https://github.com/some/other.git")
-        let fork4 = await getFork(on: app.db, parent: parent)
+        let fork4 = await getFork(on: app.db, parent: .init(url: "https://github.com/some/other.git"))
         XCTAssertEqual(fork4, .parentURL("https://github.com/some/other.git"))
 
         // test lookup when parent url is nil
-        parent = nil
-        let fork5 = await getFork(on: app.db, parent: parent)
+        let fork5 = await getFork(on: app.db, parent: nil)
         XCTAssertEqual(fork5, nil)
     }
 }