let 'swiftVerRegex' is not concurrency-safe because non-'Sendable' type 'NSRegularExpression' may have shared mutable state

Author: finestructure

Sources/App/Core/SwiftVersion.swift

@@ -30,9 +30,9 @@ struct SwiftVersion: Content, Equatable, Hashable {
 
 extension SwiftVersion: LosslessStringConvertible {
     init?(_ string: String) {
-        let groups = swiftVerRegex.matchGroups(string)
+        let groups = Self.swiftVerRegex.matchGroups(string)
         guard
-            groups.count == swiftVerRegex.numberOfCaptureGroups,
+            groups.count == Self.swiftVerRegex.numberOfCaptureGroups,
             let major = Int(groups[0])
         else { return nil }
         self = .init(major, Int(groups[1]) ?? 0, Int(groups[2]) ?? 0)
@@ -71,6 +71,24 @@ extension SwiftVersion: LosslessStringConvertible {
 
         }
     }
+
+    static var swiftVerRegex: NSRegularExpression {
+        NSRegularExpression(
+            #"""
+            ^
+            v?                              # SPI extension: allow leading 'v'
+            (?<major>0|[1-9]\d*)
+            (?:\.
+              (?<minor>0|[1-9]\d*)
+            )?
+            (?:\.
+              (?<patch>0|[1-9]\d*)
+            )?
+            $
+            """#, options: [.allowCommentsAndWhitespace]
+        )
+    }
+
 }
 
 
@@ -100,17 +118,3 @@ extension SwiftVersion {
 extension SwiftVersion {
     static var latest: Self { allActive.sorted().last! }
 }
-
-
-let swiftVerRegex = NSRegularExpression(#"""
-^
-v?                              # SPI extension: allow leading 'v'
-(?<major>0|[1-9]\d*)
-(?:\.
-  (?<minor>0|[1-9]\d*)
-)?
-(?:\.
-  (?<patch>0|[1-9]\d*)
-)?
-$
-"""#, options: [.allowCommentsAndWhitespace])

Tests/AppTests/SwiftVersionTests.swift

@@ -20,13 +20,13 @@ import XCTest
 class SwiftVersionTests: XCTestCase {
 
     func test_swiftVerRegex() throws {
-        XCTAssert(swiftVerRegex.matches("1"))
-        XCTAssert(swiftVerRegex.matches("1.2"))
-        XCTAssert(swiftVerRegex.matches("1.2.3"))
-        XCTAssert(swiftVerRegex.matches("v1"))
-        XCTAssertFalse(swiftVerRegex.matches("1."))
-        XCTAssertFalse(swiftVerRegex.matches("1.2."))
-        XCTAssertFalse(swiftVerRegex.matches("1.2.3-pre"))
+        XCTAssert(SwiftVersion.swiftVerRegex.matches("1"))
+        XCTAssert(SwiftVersion.swiftVerRegex.matches("1.2"))
+        XCTAssert(SwiftVersion.swiftVerRegex.matches("1.2.3"))
+        XCTAssert(SwiftVersion.swiftVerRegex.matches("v1"))
+        XCTAssertFalse(SwiftVersion.swiftVerRegex.matches("1."))
+        XCTAssertFalse(SwiftVersion.swiftVerRegex.matches("1.2."))
+        XCTAssertFalse(SwiftVersion.swiftVerRegex.matches("1.2.3-pre"))
     }
 
     func test_init() throws {