Remove unused AppError.invalidPackageUrl

Author: finestructure

Sources/App/Commands/Common.swift

@@ -121,8 +121,6 @@ func recordError(database: Database,
             try await setStatus(id: id, status: .invalidCachePath)
         case let .cacheDirectoryDoesNotExist(id, _):
             try await setStatus(id: id, status: .cacheDirectoryDoesNotExist)
-        case let .invalidPackageUrl(id, _):
-            try await setStatus(id: id, status: .invalidUrl)
         case let .invalidRevision(id, _):
             try await setStatus(id: id, status: .analysisFailed)
         case let .metadataRequestFailed(id, _, _):

Sources/App/Core/AppError.swift

@@ -18,7 +18,6 @@ import Vapor
 enum AppError: LocalizedError {
     case analysisError(Package.Id?, _ message: String)
     case envVariableNotSet(_ variable: String)
-    case invalidPackageUrl(Package.Id?, _ url: String)
     case invalidPackageCachePath(Package.Id?, _ path: String)
     case cacheDirectoryDoesNotExist(Package.Id?, _ path: String)
     case invalidRevision(Version.Id?, _ revision: String?)
@@ -34,8 +33,6 @@ enum AppError: LocalizedError {
                 return "Analysis failed: \(message) (id: \(id))"
             case let .envVariableNotSet(value):
                 return "Environment variable not set: \(value)"
-            case let .invalidPackageUrl(id, value):
-                return "Invalid packge URL: \(value) (id: \(id))"
             case let .invalidPackageCachePath(id, value):
                 return "Invalid packge cache path: \(value) (id: \(id))"
             case let .cacheDirectoryDoesNotExist(id, value):

Tests/AppTests/ErrorReportingTests.swift

@@ -22,11 +22,11 @@ class ErrorReportingTests: AppTestCase {
     func test_recordError() async throws {
         let pkg = try await savePackageAsync(on: app.db, "1")
         try await recordError(database: app.db,
-                              error: AppError.invalidPackageUrl(pkg.id, "foo"),
+                              error: AppError.cacheDirectoryDoesNotExist(pkg.id, "path"),
                               stage: .ingestion)
         do {
             let pkg = try fetch(id: pkg.id, on: app.db)
-            XCTAssertEqual(pkg.status, .invalidUrl)
+            XCTAssertEqual(pkg.status, .cacheDirectoryDoesNotExist)
             XCTAssertEqual(pkg.processingStage, .ingestion)
         }
     }

Tests/AppTests/Util+ext.swift

@@ -94,8 +94,6 @@ extension App.AppError: Swift.Equatable {
                 return (id1, v1) == (id2, v2)
             case let (.invalidPackageCachePath(id1, v1), .invalidPackageCachePath(id2, v2)):
                 return (id1, v1) == (id2, v2)
-            case let (.invalidPackageUrl(id1, v1), .invalidPackageUrl(id2, v2)):
-                return (id1, v1) == (id2, v2)
             case let (.invalidRevision(id1, v1), .invalidRevision(id2, v2)):
                 return (id1, v1) == (id2, v2)
             case let (.metadataRequestFailed(id1, s1, u1), .metadataRequestFailed(id2, s2, u2)):