Remove Current.shell

Author: finestructure

Sources/App/Core/AppEnvironment.swift

@@ -25,7 +25,6 @@ import FoundationNetworking
 struct AppEnvironment: Sendable {
     var logger: @Sendable () -> Logger
     var setLogger: @Sendable (Logger) -> Void
-    var shell: Shell
 }
 
 
@@ -34,16 +33,7 @@ extension AppEnvironment {
 
     static let live = AppEnvironment(
         logger: { logger },
-        setLogger: { logger in Self.logger = logger },
-        shell: .live
-    )
-}
-
-
-
-@available(*, deprecated)
-struct Shell: Sendable {
-    static let live: Self = .init(
+        setLogger: { logger in Self.logger = logger }
     )
 }
 

Tests/AppTests/GitLiveTests.swift

@@ -34,7 +34,6 @@ class GitLiveTests: XCTestCase {
         // Simulate a class setUp (which does not exist as an async function)
         if Self.hasRunSetup { return }
         Self.hasRunSetup = true
-        Current.shell = .live
         try! Foundation.FileManager.default.createDirectory(atPath: Self.tempDir, withIntermediateDirectories: false, attributes: nil)
         try! await ShellOut.shellOut(to: .init(command: "unzip", arguments: [Self.sampleGitRepoZipFile]), at: Self.tempDir)
     }

Tests/AppTests/Mocks/AppEnvironment+mock.swift

@@ -23,8 +23,7 @@ extension AppEnvironment {
     static func mock(eventLoop: EventLoop) -> Self {
         .init(
             logger: { logger },
-            setLogger: { logger in Self.logger = logger },
-            shell: .mock
+            setLogger: { logger in Self.logger = logger }
         )
     }
 }

Tests/AppTests/Mocks/AppShell+mock.swift

@@ -88,7 +88,7 @@ class ReAnalyzeVersionsTests: AppTestCase {
                     XCTAssertEqual(versions.map { $0.targets.map(\.name) } , [[], []])
                     XCTAssertEqual(versions.map(\.releaseNotes) , [nil, nil])
                 }
-                
+
                 try await withDependencies {
                     // Update state that would normally not be affecting existing versions, effectively simulating the situation where we only started parsing it after versions had already been created
                     $0.shell.run = { @Sendable cmd, path in