Merge pull request #3593 from SwiftPackageIndex/transient-dependency-note

daveverwer · web-flow · commit bc1b2f208ab2 · 2025-01-13T09:57:20.000Z
Added a note clarifying the dependency count to the package metadata
diff --git a/FrontEnd/styles/package.scss b/FrontEnd/styles/package.scss
@@ -96,7 +96,9 @@
             }
 
             li.dependencies {
+                display: flex;
                 grid-column-start: span 2;
+                flex-direction: column;
                 background-image: var(--image-dependencies);
             }
 
diff --git a/Sources/App/Views/PackageController/GetRoute.Model+ext.swift b/Sources/App/Views/PackageController/GetRoute.Model+ext.swift
@@ -319,7 +319,12 @@ extension API.PackageController.GetRoute.Model {
 
         return .li(
             .class("dependencies"),
-            .text(dependenciesPhrase)
+            .div(
+                .text(dependenciesPhrase)
+            ),
+            .small(
+                .text("Including all transitive and test dependencies.")
+            )
         )
     }
 
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_app_store_incompatible_license.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_app_store_incompatible_license.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license warning">
                   <a href="https://example.com/license.html" title="GNU General Public License v3.0">GPL 3.0</a> licensed
                   <a class="more-info" href="/faq#licenses">Why might the GPL 3.0 be problematic?</a>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_binary_targets.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_binary_targets.1.html
@@ -165,7 +165,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_canonicalURL_noImageSnapshots.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_canonicalURL_noImageSnapshots.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_customCollection.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_customCollection.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="custom-collections">Member of the 
                   <a href="/collections/custom-collection">Custom Collection</a> collection.
                 </li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_emoji_summary.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_emoji_summary.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_few_keywords.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_few_keywords.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_many_keywords.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_many_keywords.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_no_authors_activity.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_no_authors_activity.1.html
@@ -156,7 +156,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/commits/main">1,433 commits</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/releases">79 releases</a>.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_no_builds.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_no_builds.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_no_license.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_no_license.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license error">
                   <span class="no-license">No license</span>
                   <a class="more-info" href="/faq#licenses">Why should you not use unlicensed code?</a>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_open_source_license.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_open_source_license.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license">
                   <a href="https://example.com/license.html" title="MIT License">MIT</a> licensed
                 </li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_other_license.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_other_license.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license warning">
                   <a href="https://example.com/license.html">Unknown license</a>
                   <a class="more-info" href="/faq#licenses">Why is this package's license unknown?</a>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_single_row_tables.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_single_row_tables.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_withPackageFundingLinks.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_withPackageFundingLinks.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>
diff --git a/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_with_documentation_link.1.html b/Tests/AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_with_documentation_link.1.html
@@ -161,7 +161,10 @@ <h4>When working with a Swift Package Manager manifest:</h4>
                   <a href="https://github.com/Alamofire/Alamofire/issues">27 open issues</a> and 
                   <a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
                 </li>
-                <li class="dependencies">This package depends on 2 other packages.</li>
+                <li class="dependencies">
+                  <div>This package depends on 2 other packages.</div>
+                  <small>Including all transitive and test dependencies.</small>
+                </li>
                 <li class="license"> licensed</li>
                 <li class="stars">17 stars</li>
                 <li class="libraries">3 libraries</li>

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,9 @@`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`li.dependencies {`
	`99`	`+ display: flex;`
`99`	`100`	`grid-column-start: span 2;`
	`101`	`+ flex-direction: column;`
`100`	`102`	`background-image: var(--image-dependencies);`
`101`	`103`	`}`
`102`	`104`
Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,12 @@ extension API.PackageController.GetRoute.Model {`
`319`	`319`
`320`	`320`	`return .li(`
`321`	`321`	`.class("dependencies"),`
`322`		`- .text(dependenciesPhrase)`
	`322`	`+ .div(`
	`323`	`+ .text(dependenciesPhrase)`
	`324`	`+ ),`
	`325`	`+ .small(`
	`326`	`+ .text("Including all transitive and test dependencies.")`
	`327`	`+ )`
`323`	`328`	`)`
`324`	`329`	`}`
`325`	`330`