Convert SQLKitExtensionTests

Author: finestructure

Tests/AppTests/AppTestCase.swift

@@ -182,7 +182,7 @@ extension AppTestCase {
 }
 
 
-// FIXME: Move this once AppTestCase can be removed. These are helpers created during the transition to Swift Testing.
+// FIXME: Move this once AppTestCase can be removed. These are helpers created during the transition to Swift Testing. Also check if we can just create a PostgresDB object from scratch rather than using withApp and app.db for this at the call site. That does a whole migration + reset just to render the SQL needlessly.
 extension Database {
     func renderSQL(_ builder: SQLSelectBuilder) -> String {
         renderSQL(builder.query)

Tests/AppTests/SQLKitExtensionTests.swift

@@ -15,27 +15,30 @@
 @testable import App
 
 import SQLKit
-import XCTest
+import Testing
 
 
-class SQLKitExtensionTests: AppTestCase {
+@Suite struct SQLKitExtensionTests {
 
-    func test_OrderByGroup() throws {
-        let b = SQLOrderBy(SQLIdentifier("id"), .ascending)
-            .then(SQLIdentifier("foo"), .descending)
-        XCTAssertEqual(renderSQL(b), #""id" ASC, "foo" DESC"#)
+    @Test func OrderByGroup() async throws {
+        try await withApp { app in
+            let b = SQLOrderBy(SQLIdentifier("id"), .ascending)
+                .then(SQLIdentifier("foo"), .descending)
+            #expect(app.db.renderSQL(b) == #""id" ASC, "foo" DESC"#)
+        }
     }
 
-    func test_OrderByGroup_complex() throws {
-        let packageName = SQLIdentifier("package_name")
-        let mergedTerms = SQLBind("a b")
-        let score = SQLIdentifier("score")
-
-        let orderBy = SQLOrderBy(eq(lower(packageName), mergedTerms), .descending)
-            .then(score, .descending)
-            .then(packageName, .ascending)
-        XCTAssertEqual(renderSQL(orderBy),
-                       #"LOWER("package_name") = $1 DESC, "score" DESC, "package_name" ASC"#)
+    @Test func OrderByGroup_complex() async throws {
+        try await withApp { app in
+            let packageName = SQLIdentifier("package_name")
+            let mergedTerms = SQLBind("a b")
+            let score = SQLIdentifier("score")
+
+            let orderBy = SQLOrderBy(eq(lower(packageName), mergedTerms), .descending)
+                .then(score, .descending)
+                .then(packageName, .ascending)
+            #expect(app.db.renderSQL(orderBy) == #"LOWER("package_name") = $1 DESC, "score" DESC, "package_name" ASC"#)
+        }
     }
 
 }