Add support for Mermaid charts to README files #3499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Supercedes #3474
Well, what a rabbit hole this turned out to be!
Thank you so much @leogdion for this contribution, and please don’t take the fact that I completely rewrote it as any slight on your code.
Once I realised what you were doing with removing and then re-populating the
preelement with the Mermaid source, it didn’t seem like the best approach. I changed things around and now we userenderonmermaidto grab SVG data directly and insert both a light and dark mode chart into a new container.This has several advantages:
prestyling with a grey background. I think it looks better this way, and it gives more options for future styling.The disadvantage is that we now need to render every chart twice. I can’t see that this would be a performance problem, but it’s something to watch out for.
Thank you again. This is a great step forward for README files on SPI!