Skip to content

Gate custom collection links on the Package page to staging #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Gate custom collection links on the Package page to staging #3539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ba1dd
Gate the custom collection metadata to staging until the blog post is…
daveverwer Dec 5, 2024
cc519fe
Snapshots.
daveverwer Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/App/Views/PackageController/GetRoute.Model+ext.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,10 @@ extension API.PackageController.GetRoute.Model {
}

func customCollectionsListItem() -> Node<HTML.ListContext> {
@Dependency(\.environment) var environment
guard environment.current() == .development
else { return .empty }

guard customCollections.isEmpty == false
else { return .empty }

Expand Down
3 changes: 0 additions & 3 deletions .../AppTests/__Snapshots__/WebpageSnapshotTests/test_PackageShowView_customCollection.1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,6 @@ <h4>When working with a Swift Package Manager manifest:</h4>
<a href="https://github.com/Alamofire/Alamofire/pulls">5 open pull requests</a>. The last issue was closed 5 days ago and the last pull request was merged/closed 6 days ago.
</li>
<li class="dependencies">This package depends on 2 other packages.</li>
<li class="custom-collections">Member of the
<a href="/collections/custom-collection">Custom Collection</a> collection.
</li>
<li class="license"> licensed</li>
<li class="stars">17 stars</li>
<li class="libraries">3 libraries</li>
Expand Down
Loading