Fix performance issue #3713
Merged
Fix performance issue #3713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
commented
Mar 5, 2025
| } | ||
|
|
||
| var scoreCategories: [PackageScore] { | ||
| func scoreCategories() -> [PackageScore] { |
There was a problem hiding this comment.
scoreCategories is not a cheap computation and it's best practice not to make them properties - sort of to signal that they're not cheap.
| .p("\(scoreCategories[index].description)") | ||
| .p("\(categories[index].title)"), | ||
| .p("\(categories[index].score) points"), | ||
| .p("\(categories[index].description)") |
There was a problem hiding this comment.
The problem is here - this function used the somewhat expensive scoreCategories multiple times and in a loop, leading to noticeably bad performance.
Making the function static makes it easy to re-use the externally computed value here. This way, there's no risk it can again accidentally be called multiple times without being aware of the cost.
daveverwer
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for slow runtime: more than half the time spent in
WebpageSnapshotTestswas spent inMaintainerInfoIndex_document(5s out of 10s on my machine).