Merge pull request #12 from SwiftRex/modernize-snapshots

melle · web-flow · commit 342795cd7424 · 2024-11-04T17:42:00.000+01:00
Modernize snapshots
diff --git a/Package.swift b/Package.swift
@@ -16,7 +16,7 @@ let package = Package(
         .library(name: "TestingExtensionsDynamic", type: .dynamic, targets: ["TestingExtensions"])
     ],
     dependencies: [
-        .package(name: "swift-snapshot-testing", url: "https://github.com/pointfreeco/swift-snapshot-testing.git", .upToNextMajor(from: "1.10.0")),
+        .package(name: "swift-snapshot-testing", url: "https://github.com/pointfreeco/swift-snapshot-testing.git", .upToNextMajor(from: "1.12.0")),
         .package(name: "SwiftRex", url: "https://github.com/SwiftRex/SwiftRex.git", .upToNextMajor(from: "0.8.12"))
     ],
     targets: [
diff --git a/Sources/TestingExtensions/SnapshotTestBase.swift b/Sources/TestingExtensions/SnapshotTestBase.swift
@@ -22,8 +22,8 @@ open class SnapshotTestBase: XCTestCase {
 
     open var defaultDevices: [(name: String, device: ViewImageConfig)] {
         [
-            ("SE", .iPhoneSe),
-            ("X", .iPhoneX),
+            ("iPhone8", .iPhone8),
+            ("iPhone13proMax", .iPhone13ProMax),
             ("iPadMini", .iPadMini(.portrait) ),
             ("iPadPro", .iPadPro12_9(.portrait))
         ]
@@ -56,7 +56,7 @@ open class SnapshotTestBase: XCTestCase {
                 }
 
                 assertSnapshot(
-                    matching: vc,
+                    of: vc,
                     as: .image(on: config.device, precision: imageDiffPrecision),
                     file: file,
                     testName: "\(testName)-\(config.name)\(suffix)",

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,8 @@ open class SnapshotTestBase: XCTestCase {`
`22`	`22`
`23`	`23`	`open var defaultDevices: [(name: String, device: ViewImageConfig)] {`
`24`	`24`	`[`
`25`		`- ("SE", .iPhoneSe),`
`26`		`- ("X", .iPhoneX),`
	`25`	`+ ("iPhone8", .iPhone8),`
	`26`	`+ ("iPhone13proMax", .iPhone13ProMax),`
`27`	`27`	`("iPadMini", .iPadMini(.portrait) ),`
`28`	`28`	`("iPadPro", .iPadPro12_9(.portrait))`
`29`	`29`	`]`
`@@ -56,7 +56,7 @@ open class SnapshotTestBase: XCTestCase {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`assertSnapshot(`
`59`		`- matching: vc,`
	`59`	`+ of: vc,`
`60`	`60`	`as: .image(on: config.device, precision: imageDiffPrecision),`
`61`	`61`	`file: file,`
`62`	`62`	`testName: "\(testName)-\(config.name)\(suffix)",`