Skip to content

Commit aaa633d

Browse files
committed
ci: remove cocoapods job requirement for deployment
1 parent df5e6e7 commit aaa633d

File tree

6 files changed

+15
-13
lines changed

6 files changed

+15
-13
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,14 @@ jobs:
8989
github.event.inputs.release == 'true' &&
9090
needs.swift-package-test.result == 'success' &&
9191
needs.xcode-test.result == 'success' &&
92-
needs.cocoapods-test.result == 'success' &&
9392
(needs.ci.result == 'success' || needs.ci.result == 'skipped'))
93+
# needs.cocoapods-test.result == 'success' &&
9494
# (needs.analyze.result == 'success' || needs.analyze.result == 'skipped')
9595
needs: [ci, swift-package-test, xcode-test]
9696
# needs: [ci, analyze, swift-package-test, xcode-test, cocoapods-test]
9797
uses: SwiftyLab/ci/.github/workflows/cd.yml@main
9898
with:
9999
version: ${{ github.event.inputs.version }}
100100
cocoapods: false
101-
secrets: inherit
101+
secrets:
102+
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ While Swift's modern structured concurrency provides safer way of managing concu
2020
- Easier task cancellation with ``CancellationSource``.
2121
- Introducing traditional synchronization primitives that work in non-blocking way with ``AsyncSemaphore`` and ``AsyncEvent``.
2222
- Bridging with Grand Central Dispatch and allowing usage of GCD specific patterns with ``TaskOperation`` and ``TaskQueue``.
23-
- Transfering data between multiple task boundaries with ``Future``.
23+
- Transferring data between multiple task boundaries with ``Future``.

Sources/AsyncObjects/AsyncObjects.docc/AsyncObjects.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ While Swift's modern structured concurrency provides safer way of managing concu
99
- Easier task cancellation with ``CancellationSource``.
1010
- Introducing traditional synchronization primitives that work in non-blocking way with ``AsyncSemaphore`` and ``AsyncEvent``.
1111
- Bridging with Grand Central Dispatch and allowing usage of GCD specific patterns with ``TaskOperation`` and ``TaskQueue``.
12-
- Transfering data between multiple task boundaries with ``Future``.
12+
- Transferring data between multiple task boundaries with ``Future``.
1313

1414
## Topics
1515

Tests/AsyncObjectsTests/CancellationSourceTests.swift

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class CancellationSourceTests: XCTestCase {
5353
let task = await Task(cancellationSource: source) {
5454
do {
5555
try await Task.sleep(nanoseconds: UInt64(10E9))
56-
XCTFail()
56+
XCTFail("Unexpected task progression")
5757
} catch {}
5858
}
5959
await source.cancel()
@@ -67,7 +67,7 @@ class CancellationSourceTests: XCTestCase {
6767
let task = await Task.detached(cancellationSource: source) {
6868
do {
6969
try await Task.sleep(nanoseconds: UInt64(10E9))
70-
XCTFail()
70+
XCTFail("Unexpected task progression")
7171
} catch {}
7272
}
7373
await source.cancel()
@@ -102,8 +102,9 @@ class CancellationSourceTests: XCTestCase {
102102
return Task(cancellationSource: source) {
103103
do {
104104
try await Task.sleep(nanoseconds: UInt64(10E9))
105+
} catch {
105106
XCTAssertTrue(Task.isCancelled)
106-
} catch {}
107+
}
107108
}
108109
}
109110

@@ -124,7 +125,7 @@ class CancellationSourceTests: XCTestCase {
124125
return Task.detached(cancellationSource: source) {
125126
do {
126127
try await Task.sleep(nanoseconds: UInt64(10E9))
127-
XCTFail()
128+
XCTFail("Unexpected task progression")
128129
} catch {}
129130
}
130131
}
@@ -146,7 +147,7 @@ class CancellationSourceTests: XCTestCase {
146147
) throws -> Task<Void, Error> {
147148
return try Task(cancellationSource: source) {
148149
try await Task.sleep(nanoseconds: UInt64(10E9))
149-
XCTFail()
150+
XCTFail("Unexpected task progression")
150151
}
151152
}
152153

@@ -168,7 +169,7 @@ class CancellationSourceTests: XCTestCase {
168169
) throws -> Task<Void, Error> {
169170
return try Task.detached(cancellationSource: source) {
170171
try await Task.sleep(nanoseconds: UInt64(10E9))
171-
XCTFail()
172+
XCTFail("Unexpected task progression")
172173
}
173174
}
174175

Tests/AsyncObjectsTests/TaskOperationTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class TaskOperationTests: XCTestCase {
3434
XCTAssertFalse(operation.isCancelled)
3535
switch await operation.result {
3636
case .success(true): break
37-
default: XCTFail()
37+
default: XCTFail("Unexpected operation result")
3838
}
3939
}
4040

@@ -59,7 +59,7 @@ class TaskOperationTests: XCTestCase {
5959
XCTAssertFalse(operation.isExecuting)
6060
XCTAssertTrue(operation.isCancelled)
6161
switch await operation.result {
62-
case .success(true): XCTFail()
62+
case .success(true): XCTFail("Unexpected operation result")
6363
default: break
6464
}
6565
}

Tests/AsyncObjectsTests/ThrowingFutureTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class ThrowingFutureTests: XCTestCase {
3131
group.addTask {
3232
do {
3333
let _ = try await future.value
34-
XCTFail()
34+
XCTFail("Unexpected task progression")
3535
} catch {
3636
XCTAssertTrue(type(of: error) == CancellationError.self)
3737
}

0 commit comments

Comments
 (0)