Skip to content

Docstring in monostatic Doppler is wrong #20

@JuergHuber

Description

@JuergHuber

The monostatic Doppler docstring says velocity directions are lon/lat/alt (supposedly implying x=lon, y=lat, z=alt):

def monostatic_doppler(
freq, rad_lat, rad_lon, rad_alt, tgt_lat, tgt_lon, tgt_alt, tgt_vx, tgt_vy, tgt_vz
):
"""computes Doppler shift in Hz from target motion as seen at ground stationary radar
freq given in MHz, alts given in masl.
returns None if tgt V == 0. tgt_V is given as m/s along the lon/lat/z axis
see Class Target definition
"""

However, the code shows it is actually x=lat, y=lon, z=alt because gx is the north-component and gy is the east-component:

gx = xy_dist * math.cos(az) # [m]
gy = xy_dist * math.sin(az) # [m]

I suggest to define coordinate systems and conventions in the documentation.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions