Add extraArgs for rclone daemon configuration (#69)

Adds support for passing custom arguments to the rclone daemon via Helm chart configuration

Author: kanya-approve

deploy/csi-rclone/templates/csi-nodeplugin-rclone.yaml

@@ -82,6 +82,10 @@ spec:
           value: {{ .Values.csiNodepluginRclone.rclone.cache.dir | quote }}
         - name: CACHE_SIZE
           value: {{ .Values.csiNodepluginRclone.rclone.cache.size | quote }}
+        {{- if .Values.csiNodepluginRclone.rclone.extraArgs }}
+        - name: EXTRA_ARGS
+          value: {{ .Values.csiNodepluginRclone.rclone.extraArgs | toJson | quote }}
+        {{- end }}
         {{- with .Values.csiNodepluginRclone.rclone.extraEnv }}
         {{- if . }}
         {{ toYaml . | nindent 8 }}

deploy/csi-rclone/values.yaml

@@ -13,7 +13,7 @@ csiControllerRclone:
   rclone:
     image:
       repository: csi-rclone
-      tag: "latest"
+      tag: latest
     imagePullPolicy: IfNotPresent
     resources:
       {}
@@ -40,7 +40,10 @@ csiNodepluginRclone:
         add:
           - SYS_ADMIN
       privileged: true
+    # Extra environment variables for the rclone container
     extraEnv: []
+    # - name: "DEBUG"
+    #   value: "true"
     image:
       repository: csi-rclone
       tag: "latest"
@@ -59,6 +62,12 @@ csiNodepluginRclone:
       dir: /var/lib/rclone/cache
       # The size allocated for the cache directory
       size: 1G
+    # Extra arguments to pass to rclone daemon
+    extraArgs: []
+    # - name: "buffer-size"
+    #   value: "32M"
+    # - name: "transfers"
+    #   value: "8"
   serviceAccount:
     annotations: {}
   nodeSelector: {}

pkg/rclone/rclone.go

@@ -424,6 +424,22 @@ func (r *Rclone) start_daemon() error {
 	if r.cacheDir != "" {
 		rclone_args = append(rclone_args, fmt.Sprintf("--cache-dir=%s", r.cacheDir))
 	}
+	// Add any extra arguments from environment variable
+	extraArgs := os.Getenv("EXTRA_ARGS")
+	if extraArgs != "" {
+		var argList []map[string]string
+		if err := json.Unmarshal([]byte(extraArgs), &argList); err == nil {
+			for _, arg := range argList {
+				if name, exists := arg["name"]; exists && name != "" {
+					if value, hasValue := arg["value"]; hasValue && value != "" {
+						rclone_args = append(rclone_args, fmt.Sprintf("--%s=%s", name, value))
+					} else {
+						rclone_args = append(rclone_args, fmt.Sprintf("--%s", name))
+					}
+				}
+			}
+		}
+	}
 	loglevel := os.Getenv("LOG_LEVEL")
 	if len(loglevel) == 0 {
 		loglevel = "NOTICE"