Skip to content

Conversation

@kanya-approve
Copy link

Attempt to address #27

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this draft!

FYI, we will most likely also look into implementing a solution to re-mount volumes in a short time so we may merge that solution instead.

sambuc pushed a commit that referenced this pull request Dec 1, 2025
sambuc added a commit that referenced this pull request Dec 3, 2025
* Merge Re-mount volumes on a restart or update #72

* Ensure the mutex is not copied, even when the nodeServer is copied by
  storing a pointer to the mutex, instead of the mutex itself

* Use Mutex instead of RWMutex, as having two readers of the variable at
  the same time means we are going to write the state at the same time,
  corrupting the state file on storage.

* Use private freestanding functions mutex as Mutex / RWMutex are not 
  recursive / re-entrant in Go.

* Improve the remounting logic by using a rate-limited amount of 
   background goroutines and adding timeouts values so that the service
   startup time is not dependent on the number of tracked volumes.

---------

Co-authored-by: Brian Kanya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants