address comments

Author: Panaetius

components/renku_data_services/storage/api.spec.yaml

@@ -515,9 +515,7 @@ components:
           minLength: 1
           maxLength: 99
         value:
-          oneOf:
-            - $ref: "#/components/schemas/SecretValue"
-            - type: 'null'
+          $ref: "#/components/schemas/SecretValueNullable"
       required:
         - name
         - value
@@ -545,11 +543,12 @@ components:
       required:
         - name
         - secret_id
-    SecretValue:
-      description: Secret value that can be any text
-      type: string
-      minLength: 1
-      maxLength: 5000
+    SecretValueNullable: 
+      description: Secret value that can be any text 
+      type: string 
+      minLength: 1 
+      maxLength: 5000 
+      nullable: true 
     RCloneSchema:
       description: List of RClone schemas for different storage types
       type: array

components/renku_data_services/storage/apispec.py

@@ -1,6 +1,6 @@
 # generated by datamodel-codegen:
 #   filename:  api.spec.yaml
-#   timestamp: 2024-09-19T13:28:18+00:00
+#   timestamp: 2024-10-07T08:21:24+00:00
 
 from __future__ import annotations
 
@@ -11,15 +11,6 @@
 from renku_data_services.storage.apispec_base import BaseAPISpec
 
 
-class SecretValue(RootModel[str]):
-    root: str = Field(
-        ...,
-        description="Secret value that can be any text",
-        max_length=5000,
-        min_length=1,
-    )
-
-
 class Example(BaseAPISpec):
     value: Optional[str] = Field(
         None, description="a potential value for the option (think enum)"
@@ -251,7 +242,12 @@ class CloudStorageSecretPost(BaseAPISpec):
         max_length=99,
         min_length=1,
     )
-    value: Optional[SecretValue] = None
+    value: Optional[str] = Field(
+        ...,
+        description="Secret value that can be any text",
+        max_length=5000,
+        min_length=1,
+    )
 
 
 class CloudStorageSecretPostList(RootModel[List[CloudStorageSecretPost]]):