Skip to content

Commit 702ce30

Browse files
authored
build: update linter (#49)
1 parent 7b74cec commit 702ce30

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

.github/workflows/test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
run: |
6060
sudo apt install libx11-dev
6161
62-
- name: golangci-lint
62+
- name: Run golangci-lint
6363
uses: golangci/golangci-lint-action@v9
6464
with:
65-
version: v2.1
65+
version: v2.6

DEVELOPING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
## Linting
2+
3+
Developers need to manually install `golangci-lint`.
4+
See: https://golangci-lint.run/docs/welcome/install/.

Makefile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@ check-format: ## Check that sources are correctly formatted
6969
check-vet: ## Check source files with `go vet`
7070
go vet ./...
7171

72+
.PHONY: lint
73+
lint: ## Lint source files with `golangci-lint run`
74+
golangci-lint run
75+
7276
##@ Code generation
7377

7478
.PHONY: renku-users-apispec
@@ -80,8 +84,6 @@ renku-users-apispec: ## Download the "users" API spec
8084
.PHONY: renku-session-apispec
8185
renku-session-apispec: ## Download the "session" API spec
8286
curl -L -o pkg/renkuapi/session/api.spec.yaml https://raw.githubusercontent.com/SwissDataScienceCenter/renku-data-services/refs/heads/main/components/renku_data_services/session/api.spec.yaml
83-
# sed -e 's/- default: "general"//g' pkg/renkuapi/users/api.spec.yaml > pkg/renkuapi/users/api.spec.new.yaml
84-
# mv pkg/renkuapi/users/api.spec.new.yaml pkg/renkuapi/users/api.spec.yaml
8587

8688
.PHONY: generate
8789
generate: pkg/renkuapi/users/users_gen.go pkg/renkuapi/session/session_gen.go ## Run go generate

0 commit comments

Comments
 (0)