fix(cli): do not freeze/unfreeze plan view model (#3599)

Co-authored-by: Ralf Grubenmann <[email protected]>

Author: olevski

renku/domain_model/dataset.py

@@ -180,7 +180,7 @@ class ImageObject(Slots):
 
     id: str
     content_url: str
-    position: str
+    position: int
 
     def __init__(self, *, content_url: str, id: str, position: int):
         id = get_path(id)
@@ -656,8 +656,9 @@ def update_metadata_from(self, other: "Dataset", exclude=None):
         # and not match the SHACL definition for Renku. This cannot be addressed in the dataset
         # providers because the dataset providers do not have access to the dataset ID which is needed
         # for setting the dataset image ID.
-        for image_ind in range(len(self.images)):
-            self.images[image_ind].id = ImageObject.generate_id(self.id, self.images[image_ind].position)
+        if isinstance(self.images, list):
+            for image_ind in range(len(self.images)):
+                self.images[image_ind].id = ImageObject.generate_id(self.id, self.images[image_ind].position)
 
     def update_metadata(self, **kwargs):
         """Updates metadata."""

renku/ui/service/serializers/workflows.py

@@ -21,6 +21,7 @@
 from marshmallow_oneofschema import OneOfSchema
 
 from renku.domain_model.dataset import DatasetCreatorsJson
+from renku.infrastructure.persistent import Persistent
 from renku.ui.cli.utils.plugins import get_supported_formats
 from renku.ui.service.serializers.common import RemoteRepositorySchema
 from renku.ui.service.serializers.rpc import JsonRPCResponse
@@ -48,9 +49,13 @@ def fix_ids(self, objs, many, **kwargs):
         """Renku up to 2.4.1 had a bug that created wrong ids for workflow file entities, this fixes those on export."""
 
         def _replace_id(obj):
-            obj.unfreeze()
+            if isinstance(obj, Persistent):
+                obj.unfreeze()
+
             obj.id = obj.id.replace("//plans/", "/")
-            obj.freeze()
+
+            if isinstance(obj, Persistent):
+                obj.freeze()
 
         if many:
             for obj in objs: