Skip to content

Commit 4726f66

Browse files
authored
fix(cli): do not error unneccesarily on session stop (#3642)
1 parent 258dc60 commit 4726f66

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

renku/core/session/session.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,10 +242,16 @@ def stop_sessions(session_provider: ISessionProvider) -> SessionStopStatus:
242242
return session_provider.session_stop(
243243
project_name=project_name, session_name=session_name, stop_all=stop_all
244244
)
245-
except errors.RenkulabSessionGetUrlError:
245+
except errors.RenkulabSessionGetUrlError as e:
246246
if provider:
247247
raise
248-
return SessionStopStatus.FAILED
248+
communication.warn(f"Didn't stop any renkulab sessions: {e}")
249+
return SessionStopStatus.SUCCESSFUL
250+
except errors.DockerError as e:
251+
if provider:
252+
raise
253+
communication.warn(f"Didn't stop any docker sessions: {e}")
254+
return SessionStopStatus.SUCCESSFUL
249255

250256
session_detail = "all sessions" if stop_all else f"session {session_name}" if session_name else "session"
251257
project_name = get_renku_project_name()

0 commit comments

Comments
 (0)