Skip to content

Commit d162392

Browse files
authored
fix(service): add support for using default values in template parameters (#3550)
1 parent 3140f48 commit d162392

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

renku/ui/service/controllers/templates_create_project.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,10 @@ def setup_template(self):
130130
self.template_version = repository.head.commit.hexsha
131131

132132
# Verify missing parameters
133-
template_parameters = {p.name for p in self.template.parameters}
133+
template_parameters = {p.name: p for p in self.template.parameters}
134134
provided_parameters = {p["key"]: p["value"] for p in self.ctx["parameters"]}
135-
missing_keys = list(template_parameters - provided_parameters.keys())
135+
missing_keys = list(template_parameters.keys() - provided_parameters.keys())
136+
missing_keys = [k for k in missing_keys if not template_parameters[k].has_default]
136137
if len(missing_keys) > 0:
137138
raise UserProjectCreationError(error_message=f"the template requires a value for '${missing_keys[0]}'")
138139

0 commit comments

Comments
 (0)