minor: consistantly show field error message before help

Author: ciyer

client/src/features/ProjectPageV2/ProjectPageContent/DataConnectors/ProjectConnectDataConnectorsModal.tsx

@@ -372,10 +372,6 @@ function ProjectLinkDataConnectorBodyAndFooter({
               pattern: /^[A-Za-z0-9._-]+(?:\/[A-Za-z0-9._-]+){0,2}$/,
             }}
           />
-          <div className="form-text">
-            Paste a data connector identifier. You can find it on the the data
-            connector&apos;s side panel
-          </div>
           <div className="invalid-feedback">
             {errors.dataConnectorIdentifier == null
               ? undefined
@@ -384,6 +380,10 @@ function ProjectLinkDataConnectorBodyAndFooter({
               ? errors.dataConnectorIdentifier.message
               : "Please provide an identifier for the data connector"}
           </div>
+          <div className="form-text">
+            Paste a data connector identifier. You can find it on the the data
+            connector&apos;s side panel
+          </div>
         </div>
         {error != null && <RtkOrNotebooksError error={error} />}
       </ModalBody>
@@ -530,10 +530,10 @@ function ProjectDoiDataConnectorBodyAndFooter({
               required: true,
             }}
           />
+          <div className="invalid-feedback">Please provide a valid DOI</div>
           <div className="form-text">
             Paste a DOI, e.g. <code>10.5281/zenodo.3831980</code>.
           </div>
-          <div className="invalid-feedback">Please provide a valid DOI</div>
         </div>
         {error !== null && <RtkOrNotebooksError error={error} />}
       </ModalBody>

client/src/features/projectsV2/fields/DescriptionFormField.tsx

@@ -50,10 +50,10 @@ export default function DescriptionFormField<T extends FieldValues>({
         )}
         rules={{ maxLength: 500, required: false }}
       />
+      <div className="invalid-feedback">Please provide a description</div>
       <FormText id={`${entityName}DescriptionHelp`} className="input-hint">
         A brief (at most 500 character) description of the {entityName}.
       </FormText>
-      <div className="invalid-feedback">Please provide a description</div>
     </div>
   );
 }

client/src/features/sessionsV2/components/SessionForm/AdvancedSettingsFields.tsx

@@ -249,12 +249,12 @@ function JsonField<T extends FieldValues>({
           />
         )}
       />
-      <FormText tag="div">{helpText}</FormText>
       {errors?.[name] && (
         <div className="invalid-feedback mt-0 d-block">
           {errors[name]?.message?.toString()}
         </div>
       )}
+      <FormText tag="div">{helpText}</FormText>
     </>
   );
 }

client/src/features/sessionsV2/components/SessionForm/LauncherDetailsFields.tsx

@@ -184,14 +184,14 @@ export function LauncherDetailsFields({ control }: LauncherDetailsFieldsProps) {
                       Gigabytes
                     </UncontrolledTooltip>
                   </InputGroup>
-                  <FormText>
-                    Default: {watchCurrentSessionClass.default_storage} GB, max:{" "}
-                    {watchCurrentSessionClass.max_storage} GB
-                  </FormText>
                   <div className="invalid-feedback">
                     {error?.message ||
                       "Please provide a valid value for disk storage."}
                   </div>
+                  <FormText>
+                    Default: {watchCurrentSessionClass.default_storage} GB, max:{" "}
+                    {watchCurrentSessionClass.max_storage} GB
+                  </FormText>
                 </>
               )}
               rules={{

client/src/features/sessionsV2/components/SessionModals/ModifyResourcesLauncher.tsx

@@ -236,14 +236,14 @@ export function ModifyResourcesLauncherModal({
                       Gigabytes
                     </UncontrolledTooltip>
                   </InputGroup>
-                  <FormText>
-                    Default: {watchCurrentSessionClass.default_storage} GB, max:{" "}
-                    {watchCurrentSessionClass.max_storage} GB
-                  </FormText>
                   <div className="invalid-feedback">
                     {error?.message ||
                       "Please provide a valid value for disk storage."}
                   </div>
+                  <FormText>
+                    Default: {watchCurrentSessionClass.default_storage} GB, max:{" "}
+                    {watchCurrentSessionClass.max_storage} GB
+                  </FormText>
                 </>
               )}
               rules={{

client/src/features/sessionsV2/components/SessionModals/SelectResourceClass.tsx

@@ -219,14 +219,14 @@ export function SelectResourceClassModal({
                       Gigabytes
                     </UncontrolledTooltip>
                   </InputGroup>
-                  <FormText>
-                    Default: {watchCurrentSessionClass.default_storage} GB, max:{" "}
-                    {watchCurrentSessionClass.max_storage} GB
-                  </FormText>
                   <div className="invalid-feedback">
                     {error?.message ||
                       "Please provide a valid value for disk storage."}
                   </div>
+                  <FormText>
+                    Default: {watchCurrentSessionClass.default_storage} GB, max:{" "}
+                    {watchCurrentSessionClass.max_storage} GB
+                  </FormText>
                 </>
               )}
               rules={{