Skip to content

Commit ee58ae4

Browse files
chore: add data-cy attributes for Cypress
1 parent 04d6168 commit ee58ae4

File tree

9 files changed

+23
-8
lines changed

9 files changed

+23
-8
lines changed

client/src/components/buttons/Button.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ interface ButtonWithMenuV2Props {
125125
children?: React.ReactNode;
126126
className?: string;
127127
color?: string;
128+
dataCy?: string;
128129
default: React.ReactNode;
129130
direction?: "up" | "down" | "start" | "end";
130131
disabled?: boolean;
@@ -139,6 +140,7 @@ export function SplitButtonWithMenu({
139140
children,
140141
className,
141142
color,
143+
dataCy,
142144
default: defaultButton,
143145
direction,
144146
disabled,
@@ -168,7 +170,7 @@ export function SplitButtonWithMenu({
168170
className={cx("border-start-0", "dropdown-toggle-split")}
169171
data-bs-toggle="dropdown"
170172
color={color ?? "primary"}
171-
data-cy="button-with-menu-dropdown"
173+
data-cy={dataCy ?? "button-with-menu-dropdown"}
172174
disabled={isDisabledDropdownToggle ?? disabled}
173175
/>
174176
<DropdownMenu end>{children}</DropdownMenu>

client/src/features/ProjectPageV2/ProjectPageContent/ProjectInformation/ProjectInformation.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,9 @@ export default function ProjectInformation({
160160
title="Namespace:"
161161
>
162162
<p className="mb-0">
163-
<Link to={namespaceUrl}>{namespaceName}</Link>
163+
<Link data-cy="project-namespace-link" to={namespaceUrl}>
164+
{namespaceName}
165+
</Link>
164166
</p>
165167
</ProjectInformationBox>
166168
<ProjectInformationBox icon={<Eye className="bi" />} title="Visibility:">

client/src/features/dashboardV2/DashboardV2.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@ function UserDashboard() {
347347
<Link
348348
to={userPageUrl}
349349
className={cx("link-primary", "stretched-link")}
350+
data-cy="user-namespace-link"
350351
>
351352
@{userInfo.username ?? "unknown"}
352353
</Link>

client/src/features/dataConnectorsV2/components/DataConnectorActions.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,7 @@ function DataConnectorActionsInner({
490490
) : (
491491
<ButtonWithMenuV2
492492
color="outline-primary"
493+
dataCy="data-connector-menu-dropdown"
493494
default={
494495
<Button
495496
color="outline-primary"

client/src/features/session/components/SessionsList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ export function SessionRowResourceRequests({
353353
) : null;
354354

355355
return (
356-
<div>
356+
<div data-cy="session-view-resource-class-description">
357357
{resourceClassName && (
358358
<span key="name">
359359
<span className="text-nowrap">{resourceClassName}</span>

client/src/features/sessionsV2/DeleteSessionLauncherModal.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,12 @@ export default function DeleteSessionLauncherModal({
6969
size="lg"
7070
toggle={toggle}
7171
>
72-
<ModalHeader className="text-danger" tag="h2" toggle={toggle}>
72+
<ModalHeader
73+
className="text-danger"
74+
data-cy="delete-session-launcher-modal-title"
75+
tag="h2"
76+
toggle={toggle}
77+
>
7378
Delete session launcher
7479
</ModalHeader>
7580
<ModalBody>
@@ -107,6 +112,7 @@ export default function DeleteSessionLauncherModal({
107112
</Button>
108113
<Button
109114
color="danger"
115+
data-cy="delete-session-launcher-modal-button"
110116
disabled={result.isLoading}
111117
onClick={onDelete}
112118
type="button"

client/src/features/sessionsV2/SessionView/SessionView.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ export function SessionView({
409409
)}
410410
<div>
411411
<div className={cx("d-flex", "justify-content-between", "mb-2")}>
412-
<h3 className="my-auto">Default Resource Class</h3>
412+
<h3 className="my-auto" data-cy="session-view-resource-class-heading">Default Resource Class</h3>
413413
{launcher && (
414414
<PermissionsGuard
415415
disabled={null}
@@ -421,6 +421,7 @@ export function SessionView({
421421
onClick={toggleModifyResources}
422422
size="sm"
423423
tabIndex={0}
424+
data-cy="session-view-resource-class-edit-button"
424425
>
425426
<Pencil className="bi" />
426427
</Button>

client/src/features/sessionsV2/SessionsV2.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ export function SessionV2Actions({
211211
<>
212212
<ButtonWithMenuV2
213213
color="outline-primary"
214+
dataCy="session-launcher-menu-dropdown"
214215
default={defaultAction}
215216
preventPropagation
216217
size="sm"

client/src/features/sessionsV2/components/SessionModals/ModifyResourcesLauncher.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,15 +168,15 @@ export function ModifyResourcesLauncherModal({
168168
size="lg"
169169
toggle={toggleModal}
170170
>
171-
<ModalHeader tag="h2" toggle={toggleModal}>
171+
<ModalHeader tag="h2" toggle={toggleModal} data-cy="set-resource-class-modal-header">
172172
Set default resource class
173173
</ModalHeader>
174174
<ModalBody>
175175
{result.error && (
176176
<ErrorOrNotAvailableResourcePools title="Error modifying resources" />
177177
)}
178178
{result.isSuccess && (
179-
<SuccessAlert dismissible={false}>
179+
<SuccessAlert dismissible={false} data-cy="set-resource-class-modal-success-alert">
180180
<h3 className={cx("fs-6", "fw-bold")}>
181181
Default resource class updated
182182
</h3>
@@ -269,7 +269,7 @@ export function ModifyResourcesLauncherModal({
269269
)}
270270
</ModalBody>
271271
<ModalFooter>
272-
<Button color="outline-primary" onClick={toggleModal}>
272+
<Button color="outline-primary" onClick={toggleModal} data-cy="set-resource-class-modal-cancel-button">
273273
<XLg className={cx("bi", "me-1")} />
274274
Cancel
275275
</Button>
@@ -284,6 +284,7 @@ export function ModifyResourcesLauncherModal({
284284
}
285285
onClick={onSubmit}
286286
type="submit"
287+
data-cy="set-resource-class-modal-submit-button"
287288
>
288289
{result.isLoading ? (
289290
<Loader className="me-1" inline size={16} />

0 commit comments

Comments
 (0)