From b5d41fcccc46f8c6144f02c2ed16862f86f6d18b Mon Sep 17 00:00:00 2001 From: Chandrasekhar Ramakrishnan Date: Mon, 17 Nov 2025 11:55:44 +0100 Subject: [PATCH 1/7] minor: make form labels bold --- client/src/features/projectsV2/new/ProjectV2New.tsx | 6 +++--- .../components/SessionForm/SessionEnvironmentItem.tsx | 8 +++++--- client/src/styles/renku_bootstrap_customization.scss | 5 +++++ 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/client/src/features/projectsV2/new/ProjectV2New.tsx b/client/src/features/projectsV2/new/ProjectV2New.tsx index 1824acee01..847515c995 100644 --- a/client/src/features/projectsV2/new/ProjectV2New.tsx +++ b/client/src/features/projectsV2/new/ProjectV2New.tsx @@ -25,7 +25,7 @@ import { Button, Form, FormGroup, - Label, + FormText, ModalBody, ModalFooter, } from "reactstrap"; @@ -241,10 +241,10 @@ function ProjectV2CreationDetails() { />
- +
{result.error && } diff --git a/client/src/features/sessionsV2/components/SessionForm/SessionEnvironmentItem.tsx b/client/src/features/sessionsV2/components/SessionForm/SessionEnvironmentItem.tsx index 6891405f2f..1405ac6053 100644 --- a/client/src/features/sessionsV2/components/SessionForm/SessionEnvironmentItem.tsx +++ b/client/src/features/sessionsV2/components/SessionForm/SessionEnvironmentItem.tsx @@ -115,12 +115,14 @@ export function SessionEnvironmentItem({ for={`addSessionLauncherGlobalEnvironment-${id}`} >

{name}

-

+

Global environment

- {description ?

{description}

: null} -

+ {description ? ( +

{description}

+ ) : null} +

Date: Fri, 21 Nov 2025 10:21:43 +0100 Subject: [PATCH 2/7] minor: make field-labels .mb-1 --- client/src/styles/renku_bootstrap_customization.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/client/src/styles/renku_bootstrap_customization.scss b/client/src/styles/renku_bootstrap_customization.scss index 25f5b73278..9eac2116bc 100644 --- a/client/src/styles/renku_bootstrap_customization.scss +++ b/client/src/styles/renku_bootstrap_customization.scss @@ -124,6 +124,7 @@ $list-group-item-padding-y: $spacer; // Make form labels bold .form-label { font-weight: bold; + margin-bottom: $spacer * 0.25 !important; } // Adjust Accordion From 6d5b557047f92a74b9684cdfa1da7dfb4fcdd200 Mon Sep 17 00:00:00 2001 From: Chandrasekhar Ramakrishnan Date: Tue, 25 Nov 2025 10:50:30 +0100 Subject: [PATCH 3/7] minor: clean up session launcher form --- .../SessionForm/AdvancedSettingsFields.tsx | 81 +++++++++++-------- .../SessionForm/CustomEnvironmentFields.tsx | 2 +- 2 files changed, 48 insertions(+), 35 deletions(-) diff --git a/client/src/features/sessionsV2/components/SessionForm/AdvancedSettingsFields.tsx b/client/src/features/sessionsV2/components/SessionForm/AdvancedSettingsFields.tsx index 919c57b79a..5d65c9c706 100644 --- a/client/src/features/sessionsV2/components/SessionForm/AdvancedSettingsFields.tsx +++ b/client/src/features/sessionsV2/components/SessionForm/AdvancedSettingsFields.tsx @@ -43,6 +43,38 @@ function OptionalLabel() { return (Optional); } +interface FormFieldLabelProps { + info: string; + isOptional?: boolean; + label: ReactNode; + name: Path; +} + +function FormFieldLabel({ + info, + isOptional, + label, + name, +}: FormFieldLabelProps) { + return ( +

+ + {info && ( + + + + )} + {isOptional && } +
+ ); +} + function FormField({ control, errors, @@ -53,16 +85,12 @@ function FormField({ rules, type = "text", isOptional, -}: { +}: FormFieldLabelProps & { control: Control; errors?: FieldErrors; - info: string; - label: ReactNode; - name: Path; placeholder?: string; rules?: ControllerProps["rules"]; type: InputType; - isOptional?: boolean; }) { if (type === "checkbox" || type === "radio") { return ( @@ -82,20 +110,12 @@ function FormField({ return ( <> - + ({ }: JsonFieldProps) { return ( <> - - - {helpText} + ({ /> )} /> + {helpText} {errors?.[name] && (
{errors[name]?.message?.toString()} @@ -295,7 +308,7 @@ export function AdvancedSettingsFields<
-

Docker settings

+

Docker settings

diff --git a/client/src/features/sessionsV2/components/SessionForm/CustomEnvironmentFields.tsx b/client/src/features/sessionsV2/components/SessionForm/CustomEnvironmentFields.tsx index cd8cc4e45d..d0ca4c490c 100644 --- a/client/src/features/sessionsV2/components/SessionForm/CustomEnvironmentFields.tsx +++ b/client/src/features/sessionsV2/components/SessionForm/CustomEnvironmentFields.tsx @@ -130,7 +130,7 @@ export function CustomEnvironmentFields({
-

Advanced settings

+

Advanced settings

From 939727a0e6e628f6e8902de7d68e4f1b95b1fe13 Mon Sep 17 00:00:00 2001 From: Chandrasekhar Ramakrishnan Date: Tue, 25 Nov 2025 11:14:41 +0100 Subject: [PATCH 4/7] minor: clean up data connector form labels --- .../cloudStorage/AddOrEditCloudStorage.tsx | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/client/src/features/project/components/cloudStorage/AddOrEditCloudStorage.tsx b/client/src/features/project/components/cloudStorage/AddOrEditCloudStorage.tsx index 70179ed9a9..b45c60d4bd 100644 --- a/client/src/features/project/components/cloudStorage/AddOrEditCloudStorage.tsx +++ b/client/src/features/project/components/cloudStorage/AddOrEditCloudStorage.tsx @@ -395,7 +395,9 @@ function CheckboxOptionItem({ /> )} /> - + ); } @@ -434,7 +436,7 @@ function PasswordOptionItem({ const tooltipContainerId = `option-is-secret-${option.name}`; return ( <> -

@@ -514,7 +516,7 @@ function PasswordOptionItemStored({ const tooltipContainerId = `option-is-secret-${option.name}`; return ( <> -