Search the app-local directories separately first

Author: kcat

core/helpers.cpp

@@ -137,7 +137,22 @@ struct CoTaskMemDeleter {
 
 } // namespace
 
-std::vector<std::string> SearchDataFiles(const std::string_view ext, const std::string_view subdir)
+auto SearchDataFiles(const std::string_view ext) -> std::vector<std::string>
+{
+    auto srchlock = std::lock_guard{gSearchLock};
+
+    /* Search the app-local directory. */
+    auto results = std::vector<std::string>{};
+    if(auto localpath = al::getenv(L"ALSOFT_LOCAL_PATH"))
+        DirectorySearch(*localpath, ext, &results);
+    else if(auto curpath = std::filesystem::current_path(); !curpath.empty())
+        DirectorySearch(curpath, ext, &results);
+
+    return results;
+}
+
+auto SearchDataFiles(const std::string_view ext, const std::string_view subdir)
+    -> std::vector<std::string>
 {
     std::lock_guard<std::mutex> srchlock{gSearchLock};
 
@@ -150,12 +165,6 @@ std::vector<std::string> SearchDataFiles(const std::string_view ext, const std::
         return results;
     }
 
-    /* Search the app-local directory. */
-    if(auto localpath = al::getenv(L"ALSOFT_LOCAL_PATH"))
-        DirectorySearch(*localpath, ext, &results);
-    else if(auto curpath = std::filesystem::current_path(); !curpath.empty())
-        DirectorySearch(curpath, ext, &results);
-
 #if !defined(ALSOFT_UWP) && !defined(_GAMING_XBOX)
     /* Search the local and global data dirs. */
     for(const auto &folderid : std::array{FOLDERID_RoamingAppData, FOLDERID_ProgramData})
@@ -295,7 +304,22 @@ const PathNamePair &GetProcBinary()
     return procbin;
 }
 
-std::vector<std::string> SearchDataFiles(const std::string_view ext, const std::string_view subdir)
+auto SearchDataFiles(const std::string_view ext) -> std::vector<std::string>
+{
+    auto srchlock = std::lock_guard{gSearchLock};
+
+    /* Search the app-local directory. */
+    auto results = std::vector<std::string>{};
+    if(auto localpath = al::getenv("ALSOFT_LOCAL_PATH"))
+        DirectorySearch(*localpath, ext, &results);
+    else if(auto curpath = std::filesystem::current_path(); !curpath.empty())
+        DirectorySearch(curpath, ext, &results);
+
+    return results;
+}
+
+auto SearchDataFiles(const std::string_view ext, const std::string_view subdir)
+    -> std::vector<std::string>
 {
     std::lock_guard<std::mutex> srchlock{gSearchLock};
 
@@ -307,12 +331,6 @@ std::vector<std::string> SearchDataFiles(const std::string_view ext, const std::
         return results;
     }
 
-    /* Search the app-local directory. */
-    if(auto localpath = al::getenv("ALSOFT_LOCAL_PATH"))
-        DirectorySearch(*localpath, ext, &results);
-    else if(auto curpath = std::filesystem::current_path(); !curpath.empty())
-        DirectorySearch(curpath, ext, &results);
-
     /* Search local data dir */
     if(auto datapath = al::getenv("XDG_DATA_HOME"))
         DirectorySearch(std::filesystem::path{*datapath}/path, ext, &results);

core/helpers.h

@@ -19,6 +19,8 @@ inline bool AllowRTTimeLimit{true};
 
 void SetRTPriority();
 
-std::vector<std::string> SearchDataFiles(const std::string_view ext, const std::string_view subdir);
+auto SearchDataFiles(const std::string_view ext) -> std::vector<std::string>;
+auto SearchDataFiles(const std::string_view ext, const std::string_view subdir)
+    -> std::vector<std::string>;
 
 #endif /* CORE_HELPERS_H */

core/hrtf.cpp

@@ -1210,6 +1210,9 @@ std::vector<std::string> EnumerateHrtf(std::optional<std::string> pathopt)
     std::lock_guard<std::mutex> enumlock{EnumeratedHrtfLock};
     EnumeratedHrtfs.clear();
 
+    for(const auto &fname : SearchDataFiles(".mhr"sv))
+        AddFileEntry(fname);
+
     bool usedefaults{true};
     if(pathopt)
     {