🐛 fix(recurring-events): allow someday instance to standalone transition

Author: victor-enogwe

packages/backend/src/event/classes/compass.event.generator.ts

@@ -21,6 +21,8 @@ import {
   parseCompassEventDate,
 } from "@core/util/event/event.util";
 import mongoService from "@backend/common/services/mongo.service";
+import { GenericError } from "../../common/errors/generic/generic.errors";
+import { error } from "../../common/errors/handlers/error.handler";
 
 export class CompassEventFactory {
   private static async findCompassEvent(
@@ -220,7 +222,8 @@ export class CompassEventFactory {
     );
 
     if (dbEvent && isBase(dbEvent)) {
-      throw new Error(
+      throw error(
+        GenericError.BadRequest,
         `You cannot edit a base event with this option(${RecurringEventUpdateScope.THIS_EVENT})`,
       );
     }

packages/backend/src/sync/services/sync/compass.sync.processor.ts

@@ -129,6 +129,7 @@ export class CompassSyncProcessor {
       case "NIL->>RECURRENCE_BASE_CONFIRMED":
       case "STANDALONE_SOMEDAY->>STANDALONE_CONFIRMED":
       case "RECURRENCE_BASE_SOMEDAY->>RECURRENCE_BASE_CONFIRMED":
+      case "RECURRENCE_INSTANCE_SOMEDAY->>STANDALONE_CONFIRMED":
         return parser.createEvent(session);
       case "STANDALONE_SOMEDAY->>STANDALONE_SOMEDAY_CONFIRMED":
       case "STANDALONE->>STANDALONE_CONFIRMED":

packages/web/src/ducks/events/sagas/someday.sagas.ts

@@ -33,6 +33,8 @@ export function* convertSomedayToCalendarEvent({
   try {
     const gridEvent = yield* _assembleGridEvent(payload.event);
 
+    delete gridEvent.recurrence;
+
     optimisticEvent = yield* _createOptimisticGridEvent(gridEvent);
 
     yield* _editEvent(gridEvent);
@@ -45,7 +47,7 @@ export function* convertSomedayToCalendarEvent({
       );
     }
 
-    yield put(getSomedayEventsSlice.actions.insert(payload.event._id));
+    yield put(getSomedayEventsSlice.actions.insert(payload.event._id!));
     yield put(editEventSlice.actions.error());
 
     handleError(error as Error);