Skip to content

Commit 6aa0e08

Browse files
committed
fix(backend): include fields in email subscriber mapping for schema version 1
1 parent db9904e commit 6aa0e08

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

packages/backend/src/__tests__/drivers/email.driver.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,13 @@ export class EmailDriver {
4040
},
4141
tagId: string,
4242
): Promise<Response_TagSubscriber> {
43+
const fields = subscriber.fields ?? undefined;
4344
return Promise.resolve({
4445
subscriber: {
4546
tagId,
4647
...subscriber,
4748
tagged_at: new Date().toISOString(),
49+
fields,
4850
first_name: subscriber.first_name!,
4951
},
5052
});
@@ -53,9 +55,11 @@ export class EmailDriver {
5355
private static async upsertSubscriber(
5456
subscriber: Subscriber & { id: number; created_at: string },
5557
): Promise<Response_UpsertSubscriber> {
58+
const fields = subscriber.fields ?? undefined;
5659
return Promise.resolve({
5760
subscriber: {
5861
...subscriber,
62+
fields,
5963
first_name: subscriber.first_name!,
6064
},
6165
});

packages/core/src/mappers/subscriber/map.subscriber.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,23 @@ export const mapCompassUserToEmailSubscriber = (
2929
export const mapWaitlistUserToEmailSubscriber = (
3030
user: Schema_Waitlist,
3131
): Subscriber => {
32-
const subscriber: Subscriber = {
32+
if (user.schemaVersion === "1") {
33+
return {
34+
email_address: user.email,
35+
first_name: user.firstName,
36+
state: "active",
37+
fields: {
38+
"Last name": user.lastName,
39+
Birthday: "1970-01-01",
40+
Source: user.source,
41+
},
42+
};
43+
}
44+
45+
return {
3346
email_address: user.email,
34-
first_name: user.firstName,
47+
first_name: null,
3548
state: "active",
36-
fields: {
37-
"Last name": user.lastName,
38-
Birthday: "1970-01-01",
39-
Source: user.source,
40-
},
49+
fields: null,
4150
};
42-
return subscriber;
4351
};

0 commit comments

Comments
 (0)