refactor(web): rename withProvider to withOnboardingProvider for clarity

Author: tyler-dane

packages/web/src/auth/ProtectedRoute.tsx

@@ -1,4 +1,4 @@
-import React, { ReactNode, useEffect } from "react";
+import { ReactNode, useEffect } from "react";
 import { useNavigate } from "react-router-dom";
 import { AUTH_FAILURE_REASONS } from "@web/common/constants/auth.constants";
 import { ROOT_ROUTES } from "@web/common/constants/routes";

packages/web/src/views/Onboarding/OnboardingFlow.tsx

@@ -5,7 +5,7 @@ import { IS_DEV } from "@web/common/constants/env.constants";
 import { useIsMobile } from "@web/common/hooks/useIsMobile";
 import {
   useOnboarding,
-  withProvider,
+  withOnboardingProvider,
 } from "@web/views/Onboarding/components/OnboardingContext";
 import { Onboarding, OnboardingStepProps, OnboardingStepType } from "./index";
 import {
@@ -222,5 +222,5 @@ const _OnboardingFlow: React.FC = () => {
   );
 };
 
-export const OnboardingFlow = withProvider(_OnboardingFlow);
+export const OnboardingFlow = withOnboardingProvider(_OnboardingFlow);
 export default OnboardingFlow;

packages/web/src/views/Onboarding/components/OnboardingContext.tsx

@@ -49,7 +49,9 @@ export const useOnboarding = (): OnboardingContextType => {
   return context;
 };
 
-export const withProvider = (Component: React.ComponentType<any>) => {
+export const withOnboardingProvider = (
+  Component: React.ComponentType<unknown>,
+) => {
   // eslint-disable-next-line react/display-name
   return (props: any) => {
     return (

packages/web/src/views/Onboarding/steps/events/MigrationSandbox/MigrationSandbox.test.tsx

@@ -3,7 +3,7 @@ import { fireEvent, screen } from "@testing-library/react";
 import { within } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { render } from "@web/__tests__/__mocks__/mock.render";
-import { withProvider } from "../../../components/OnboardingContext";
+import { withOnboardingProvider } from "../../../components/OnboardingContext";
 import { MigrationSandbox } from "./MigrationSandbox";
 
 // Mock the useOnboardingShortcuts hook
@@ -16,7 +16,7 @@ const mockUseOnboardingShortcuts =
   require("../../../hooks/useOnboardingShortcuts").useOnboardingShortcuts;
 
 // Wrap the component with OnboardingProvider
-const SomedayMigrationWithProvider = withProvider(MigrationSandbox);
+const SomedayMigrationWithProvider = withOnboardingProvider(MigrationSandbox);
 
 // Mock required props for SomedayMigration
 const defaultProps = {

packages/web/src/views/Onboarding/steps/events/SomedaySandbox/SomedaySandbox.test.tsx

@@ -3,7 +3,7 @@ import "@testing-library/jest-dom";
 import { screen, waitFor } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { render } from "@web/__tests__/__mocks__/mock.render";
-import { withProvider } from "../../../components/OnboardingContext";
+import { withOnboardingProvider } from "../../../components/OnboardingContext";
 import { SomedaySandbox } from "./SomedaySandbox";
 
 // Mock the createAndSubmitEvents function
@@ -16,7 +16,7 @@ jest.mock("./sandbox.util", () => ({
 }));
 
 // Wrap the component with OnboardingProvider
-const SomedaySandboxWithProvider = withProvider(SomedaySandbox);
+const SomedaySandboxWithProvider = withOnboardingProvider(SomedaySandbox);
 
 // Mock required props for SomedaySandbox
 const defaultProps = {

packages/web/src/views/Onboarding/steps/oauth/SignInWithGoogle.test.tsx

@@ -9,7 +9,7 @@ import { AuthApi } from "@web/common/apis/auth.api";
 import { SyncApi } from "@web/common/apis/sync.api";
 import { ENV_WEB } from "@web/common/constants/env.constants";
 import { useGoogleLogin } from "@web/components/oauth/google/useGoogleLogin";
-import { withProvider } from "../../components/OnboardingContext";
+import { withOnboardingProvider } from "../../components/OnboardingContext";
 import { SignInWithGoogle } from "./SignInWithGoogle";
 
 // Mock the APIs
@@ -46,7 +46,7 @@ const mockUseGoogleLogin = useGoogleLogin as jest.MockedFunction<
 >;
 
 // Wrap the component with OnboardingProvider
-const SignInWithGoogleWithProvider = withProvider(SignInWithGoogle);
+const SignInWithGoogleWithProvider = withOnboardingProvider(SignInWithGoogle);
 
 describe("SignInWithGoogle", () => {
   const mockOnNext = jest.fn();