Skip to content

Commit 9a7f1ea

Browse files
committed
refactor: update keyboard event handling to use string literals and remove unused state in EventForm
1 parent b1aafd2 commit 9a7f1ea

File tree

2 files changed

+1
-32
lines changed

2 files changed

+1
-32
lines changed

packages/web/src/views/Day/components/Agenda/Agenda.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export function Agenda() {
6565
});
6666

6767
const onEnterKey = useCallback((e: React.KeyboardEvent<HTMLDivElement>) => {
68-
if (e.key === Key.Enter) {
68+
if (e.key === "Enter") {
6969
e.preventDefault();
7070
e.stopPropagation();
7171
timedEventsGridRef.current?.click();

packages/web/src/views/Forms/EventForm/EventForm.tsx

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ export const EventForm: React.FC<Omit<FormProps, "category">> = memo(
6262
label: "1 AM",
6363
value: "01:00 AM",
6464
});
65-
const [_isShiftKeyPressed, setIsShiftKeyPressed] = useState(false);
6665
const [isFormOpen, setIsFormOpen] = useState(false);
6766
const [isEndDatePickerOpen, setIsEndDatePickerOpen] = useState(false);
6867
const [isStartDatePickerOpen, setIsStartDatePickerOpen] = useState(false);
@@ -76,36 +75,6 @@ export const EventForm: React.FC<Omit<FormProps, "category">> = memo(
7675

7776
const descriptionRef = useRef<HTMLTextAreaElement>(null);
7877

79-
/*********
80-
* Effects
81-
*********/
82-
83-
const keyDownHandler = useCallback(
84-
(e: globalThis.KeyboardEvent) => {
85-
if (e.key === "Shift") {
86-
setIsShiftKeyPressed(true);
87-
}
88-
},
89-
[_onClose],
90-
);
91-
92-
const keyUpHandler = useCallback((e: globalThis.KeyboardEvent) => {
93-
if (e.key === "Shift") {
94-
setIsShiftKeyPressed(false);
95-
}
96-
}, []);
97-
98-
useEffect(() => {
99-
window.addEventListener("keydown", keyDownHandler);
100-
window.addEventListener("keyup", keyUpHandler);
101-
102-
return () => {
103-
window.removeEventListener("keydown", keyDownHandler);
104-
window.removeEventListener("keyup", keyUpHandler);
105-
};
106-
// eslint-disable-next-line react-hooks/exhaustive-deps
107-
}, []);
108-
10978
useEffect(() => {
11079
setEvent(event || {});
11180

0 commit comments

Comments
 (0)