Skip to content

Commit c4d387f

Browse files
committed
fix(cli): validate packages after they're provided
1 parent 0eaa112 commit c4d387f

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

packages/scripts/src/cli.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,11 @@ class CompassCli {
6464
}
6565

6666
public async run() {
67-
const { user, force, packages } = this.options;
67+
const { user, force } = this.options;
6868
const cmd = this.program.args[0];
6969

7070
switch (true) {
7171
case cmd === "build": {
72-
validatePackages(packages);
7372
await runBuild(this.options);
7473
break;
7574
}

packages/scripts/src/commands/build.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,12 @@ import {
1616
getClientId,
1717
getApiBaseUrl,
1818
getEnvironmentAnswer,
19+
validatePackages,
1920
} from "@scripts/common/cli.utils";
2021

2122
export const runBuild = async (options: Options_Cli) => {
22-
const pckgs =
23-
options?.packages?.length === 0
24-
? await getPckgsTo("build")
25-
: (options.packages as string[]);
23+
const pckgs = options.packages ? options.packages : await getPckgsTo("build");
24+
validatePackages(pckgs);
2625

2726
if (pckgs.includes(PCKG.NODE)) {
2827
await buildNodePckgs(options);

packages/scripts/src/common/cli.utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ export const validateOptions = (options: Options_Cli): Options_Cli => {
176176

177177
export const validatePackages = (packages: string[] | undefined) => {
178178
if (!packages) {
179-
log.error("Packages must be defined");
179+
log.error("Package must be defined");
180180
process.exit(1);
181181
}
182182
const unsupportedPackages = packages.filter(

0 commit comments

Comments
 (0)