Skip to content

Commit f01159d

Browse files
committed
🧹 Chore: fix type issues in sidebar hooks
1 parent 0cb8a54 commit f01159d

File tree

3 files changed

+10
-19
lines changed

3 files changed

+10
-19
lines changed

packages/web/src/views/Calendar/components/Draft/sidebar/context/SidebarDraftContext.tsx

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
11
import { createContext } from "react";
2-
import { useDraftForm } from "../../hooks/state/useDraftForm";
32
import { Actions_Sidebar } from "../hooks/useSidebarActions";
4-
import { Setters_Sidebar, State_Sidebar_Local } from "../hooks/useSidebarState";
5-
6-
export type Props_SidebarForm = ReturnType<typeof useDraftForm>;
7-
8-
export interface State_Sidebar extends State_Sidebar_Local {
9-
formProps: Props_SidebarForm;
10-
}
3+
import { Setters_Sidebar, State_Sidebar } from "../hooks/useSidebarState";
114

125
interface SidebarDraftContextValue {
136
state: State_Sidebar;

packages/web/src/views/Calendar/components/Draft/sidebar/hooks/useSidebarActions.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import {
2828
} from "@web/common/utils/web.date.util";
2929
import {
3030
selectDraft,
31+
selectDraftCategory,
3132
selectIsDrafting,
3233
} from "@web/ducks/events/selectors/draft.selectors";
3334
import {
@@ -43,11 +44,11 @@ import {
4344
import { getSomedayEventsSlice } from "@web/ducks/events/slices/someday.slice";
4445
import { useAppDispatch, useAppSelector } from "@web/store/store.hooks";
4546
import { DateCalcs } from "@web/views/Calendar/hooks/grid/useDateCalcs";
46-
import { Setters_Sidebar, State_Sidebar_Local } from "./useSidebarState";
47+
import { Setters_Sidebar, State_Sidebar } from "./useSidebarState";
4748

4849
export const useSidebarActions = (
4950
dateCalcs: DateCalcs,
50-
state: State_Sidebar_Local,
51+
state: State_Sidebar,
5152
setters: Setters_Sidebar,
5253
) => {
5354
const dispatch = useAppDispatch();
@@ -57,11 +58,11 @@ export const useSidebarActions = (
5758
const isAtMonthlyLimit = useAppSelector(selectIsAtMonthlyLimit);
5859
const { start, end } = useAppSelector(selectDatesInView);
5960
const reduxDraft = useAppSelector(selectDraft);
61+
const draftType = useAppSelector(selectDraftCategory);
62+
6063
const viewStart = dayjs(start);
6164
const viewEnd = dayjs(end);
6265

63-
const { draft, draftType } = state;
64-
6566
const { setDraft, setIsDrafting, setIsSomedayFormOpen, setSomedayEvents } =
6667
setters;
6768

@@ -165,14 +166,14 @@ export const useSidebarActions = (
165166
}, [setDraft]);
166167

167168
const discard = useCallback(() => {
168-
if (draft) {
169+
if (state.draft) {
169170
setDraft(null);
170171
}
171172

172173
if (reduxDraft) {
173174
dispatch(draftSlice.actions.discard());
174175
}
175-
}, [dispatch, draft, reduxDraft]);
176+
}, [dispatch, state.draft, reduxDraft]);
176177

177178
const getDatesAfterDroppingOn = (
178179
target: "mainGrid" | "alldayRow",

packages/web/src/views/Calendar/components/Draft/sidebar/hooks/useSidebarState.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
import { useEffect, useState } from "react";
22
import { Schema_Event } from "@core/types/event.types";
33
import { COLUMN_MONTH, COLUMN_WEEK } from "@web/common/constants/web.constants";
4-
import {
5-
selectDraftStatus,
6-
selectIsDNDing,
7-
} from "@web/ducks/events/selectors/draft.selectors";
4+
import { selectIsDNDing } from "@web/ducks/events/selectors/draft.selectors";
85
import { selectCategorizedEvents } from "@web/ducks/events/selectors/someday.selectors";
96
import { useAppSelector } from "@web/store/store.hooks";
107
import { Measurements_Grid } from "@web/views/Calendar/hooks/grid/useGridLayout";
@@ -72,5 +69,5 @@ export const useSidebarState = (measurements: Measurements_Grid) => {
7269
};
7370

7471
type Hook_Sidebar = ReturnType<typeof useSidebarState>;
75-
export type State_Sidebar_Local = Hook_Sidebar["state"];
72+
export type State_Sidebar = Hook_Sidebar["state"];
7673
export type Setters_Sidebar = Hook_Sidebar["setters"];

0 commit comments

Comments
 (0)