Merge pull request #6 from Syax89/claude/code-review-testing-o31VM

Claude/code review testing o31 vm

Author: Syax89

CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to this project are documented in this file.
 
+## [1.4.8] - 2026-03-14
+
+### Fixed
+- **Tire Pressure Sensors**: Fixed all four tire pressure sensors showing `0 PSI` instead of "unavailable" when no data is present from the vehicle.
+- **Circuit Breaker Recovery**: Fixed the circuit breaker not resetting its failure counter after the cooldown period, which caused it to re-open immediately on the first subsequent error.
+- **Entity Stability**: Fixed a `KeyError` crash that occurred when a vehicle was removed from the Geotab fleet while the integration was running. Entities now gracefully become "unavailable".
+- **Code Cleanup**: Removed unused `DeviceInfo` import from `device_tracker.py`.
+
 ## [1.4.7] - 2026-03-08
 
 ### Fixed

custom_components/geotab/__init__.py

@@ -73,6 +73,7 @@ async def async_update_data():
                 raise UpdateFailed(f"Circuit breaker open, retrying in {remaining}s")
             _LOGGER.info("Geotab circuit breaker: attempting reset.")
             circuit_open_since = None
+            consecutive_failures = 0
 
         # Determine if we should fetch trips this cycle
         now = dt_util.utcnow().timestamp()

custom_components/geotab/device_tracker.py

@@ -7,7 +7,6 @@
 from homeassistant.components.device_tracker import SourceType, TrackerEntity
 from homeassistant.config_entries import ConfigEntry
 from homeassistant.core import HomeAssistant, callback
-from homeassistant.helpers.entity import DeviceInfo
 from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from homeassistant.helpers.update_coordinator import (
     DataUpdateCoordinator,

custom_components/geotab/entity.py

@@ -22,10 +22,15 @@ def __init__(
         super().__init__(coordinator)
         self._device_id = device_id
 
+    @property
+    def available(self) -> bool:
+        """Return True if the device is still present in coordinator data."""
+        return super().available and self._device_id in self.coordinator.data
+
     @property
     def device_data(self) -> dict:
         """Return the device data for this entity."""
-        return self.coordinator.data[self._device_id]
+        return self.coordinator.data.get(self._device_id, {})
 
     @property
     def device_info(self) -> DeviceInfo:

custom_components/geotab/manifest.json

@@ -7,6 +7,6 @@
   "iot_class": "cloud_polling",
   "issue_tracker": "https://github.com/Syax89/geotab-hacs-integration/issues",
   "requirements": ["mygeotab>=0.9.1,<1.0.0"],
-  "version": "1.4.7"
+  "version": "1.4.8"
 }
 

custom_components/geotab/sensor.py

@@ -255,7 +255,11 @@ class GeotabSensorEntityDescription(SensorEntityDescription):
         state_class=SensorStateClass.MEASUREMENT,
         entity_category=EntityCategory.DIAGNOSTIC,
         suggested_display_precision=1,
-        value_fn=lambda data: (data.get("tire_pressure_front_left") or 0) * PA_TO_PSI,
+        value_fn=lambda data: (
+            data.get("tire_pressure_front_left") * PA_TO_PSI
+            if data.get("tire_pressure_front_left") is not None
+            else None
+        ),
     ),
     GeotabSensorEntityDescription(
         key="tire_pressure_front_right",
@@ -266,7 +270,11 @@ class GeotabSensorEntityDescription(SensorEntityDescription):
         state_class=SensorStateClass.MEASUREMENT,
         entity_category=EntityCategory.DIAGNOSTIC,
         suggested_display_precision=1,
-        value_fn=lambda data: (data.get("tire_pressure_front_right") or 0) * PA_TO_PSI,
+        value_fn=lambda data: (
+            data.get("tire_pressure_front_right") * PA_TO_PSI
+            if data.get("tire_pressure_front_right") is not None
+            else None
+        ),
     ),
     GeotabSensorEntityDescription(
         key="tire_pressure_rear_left",
@@ -277,7 +285,11 @@ class GeotabSensorEntityDescription(SensorEntityDescription):
         state_class=SensorStateClass.MEASUREMENT,
         entity_category=EntityCategory.DIAGNOSTIC,
         suggested_display_precision=1,
-        value_fn=lambda data: (data.get("tire_pressure_rear_left") or 0) * PA_TO_PSI,
+        value_fn=lambda data: (
+            data.get("tire_pressure_rear_left") * PA_TO_PSI
+            if data.get("tire_pressure_rear_left") is not None
+            else None
+        ),
     ),
     GeotabSensorEntityDescription(
         key="tire_pressure_rear_right",
@@ -288,7 +300,11 @@ class GeotabSensorEntityDescription(SensorEntityDescription):
         state_class=SensorStateClass.MEASUREMENT,
         entity_category=EntityCategory.DIAGNOSTIC,
         suggested_display_precision=1,
-        value_fn=lambda data: (data.get("tire_pressure_rear_right") or 0) * PA_TO_PSI,
+        value_fn=lambda data: (
+            data.get("tire_pressure_rear_right") * PA_TO_PSI
+            if data.get("tire_pressure_rear_right") is not None
+            else None
+        ),
     ),
     GeotabSensorEntityDescription(
         key="accelerator_pos",

tests/test_api.py

@@ -61,7 +61,7 @@ async def test_api_get_data(mock_geotab_api):
     assert "device1" in data
     assert data["device1"]["name"] == "Test Vehicle"
     assert data["device1"]["isDriving"] is True
-    assert data["device1"]["odometer"] == 100000
+    assert data["device1"]["odometer"] == 53203700
 
 
 @pytest.mark.asyncio