"Refactor Configuration methods to add PHPStan annotations and simplify ignore rules for NodeBuilder-related false positives."

Author: tomkalon

phpstan.neon

@@ -9,3 +9,13 @@ parameters:
     paths:
         - 'src/TwigExtra/src'
         - 'src/TwigHooks/src'
+
+    ignoreErrors:
+        # Symfony Config component relies on magic methods in NodeBuilder.
+        # PHPStan struggles to resolve these methods on the builder class when complex generics are involved,
+        # resulting in false positive "unknown class" errors.
+        -
+            message: '#Call to method \w+Node\(\) on an unknown class .*NodeBuilder.*#'
+            paths:
+                - 'src/TwigHooks/src/DependencyInjection/Configuration.php'
+                - 'src/TwigExtra/src/Symfony/DependencyInjection/Configuration.php'

src/TwigExtra/src/Symfony/DependencyInjection/Configuration.php

@@ -14,22 +14,34 @@
 namespace Sylius\TwigExtra\Symfony\DependencyInjection;
 
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
+use Symfony\Component\Config\Definition\Builder\NodeParentInterface;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 
 final class Configuration implements ConfigurationInterface
 {
+    /**
+     * @phpstan-return TreeBuilder<'array'>
+     */
     public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('sylius_twig_extra');
 
+        /**
+         * @var ArrayNodeDefinition $rootNode
+         * @phpstan-var ArrayNodeDefinition<NodeParentInterface|null> $rootNode
+         */
         $rootNode = $treeBuilder->getRootNode();
 
         $this->addTwigUxConfiguration($rootNode);
 
         return $treeBuilder;
     }
 
+    /**
+     * @param ArrayNodeDefinition $rootNode
+     * @phpstan-param ArrayNodeDefinition<NodeParentInterface|null> $rootNode
+     */
     private function addTwigUxConfiguration(ArrayNodeDefinition $rootNode): void
     {
         $rootNode

src/TwigHooks/src/DependencyInjection/Configuration.php

@@ -17,15 +17,23 @@
 use Sylius\TwigHooks\Hookable\HookableComponent;
 use Sylius\TwigHooks\Hookable\HookableTemplate;
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
+use Symfony\Component\Config\Definition\Builder\NodeParentInterface;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 
 final class Configuration implements ConfigurationInterface
 {
+    /**
+     * @phpstan-return TreeBuilder<'array'>
+     */
     public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('sylius_twig_hooks');
 
+        /**
+         * @var ArrayNodeDefinition $rootNode
+         * @phpstan-var ArrayNodeDefinition<NodeParentInterface|null> $rootNode
+         */
         $rootNode = $treeBuilder->getRootNode();
 
         $rootNode
@@ -41,6 +49,10 @@ public function getConfigTreeBuilder(): TreeBuilder
         return $treeBuilder;
     }
 
+    /**
+     * @param ArrayNodeDefinition $rootNode
+     * @phpstan-param ArrayNodeDefinition<NodeParentInterface|null> $rootNode
+     */
     private function addSupportedHookableTypesConfiguration(ArrayNodeDefinition $rootNode): void
     {
         $rootNode
@@ -58,6 +70,10 @@ private function addSupportedHookableTypesConfiguration(ArrayNodeDefinition $roo
         ;
     }
 
+    /**
+     * @param ArrayNodeDefinition $rootNode
+     * @phpstan-param ArrayNodeDefinition<NodeParentInterface|null> $rootNode
+     */
     private function addHooksConfiguration(ArrayNodeDefinition $rootNode): void
     {
         $rootNode