bug #917 Quick Fix ORM translatable listener for Symfony 5 (loic425)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets |
| License         | MIT


Commits
-------

f17ae07 Fix ORM translatable listener for Symfony 5
4a8a62c Fix coding standard

Author: GSadee

src/Bundle/AbstractResourceBundle.php

@@ -85,8 +85,6 @@ protected function getDoctrineMappingDirectory(): string
 
     /**
      * Return the entity namespace.
-     *
-     * @return string
      */
     protected function getModelNamespace(): ?string
     {

src/Bundle/EventListener/ORMTranslatableListener.php

@@ -14,8 +14,8 @@
 namespace Sylius\Bundle\ResourceBundle\EventListener;
 
 use Doctrine\Common\EventSubscriber;
-use Doctrine\ORM\Event\LifecycleEventArgs;
 use Doctrine\ORM\Event\LoadClassMetadataEventArgs;
+use Doctrine\ORM\Event\PostLoadEventArgs;
 use Doctrine\ORM\Events;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Mapping\ClassMetadataInfo;
@@ -72,7 +72,7 @@ public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs): void
         }
     }
 
-    public function postLoad(LifecycleEventArgs $args): void
+    public function postLoad(PostLoadEventArgs $args): void
     {
         $entity = $args->getObject();
 

src/Bundle/Form/EventSubscriber/AddCodeFormSubscriber.php

@@ -26,9 +26,6 @@ final class AddCodeFormSubscriber implements EventSubscriberInterface
 
     private array $options;
 
-    /**
-     * @param string $type
-     */
     public function __construct(?string $type = null, array $options = [])
     {
         $this->type = $type ?? TextType::class;

src/Bundle/Resources/config/services/integrations/translation.xml

@@ -30,8 +30,7 @@
         <service id="sylius.translation.translatable_listener.doctrine.orm" class="Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener">
             <argument type="service" id="sylius.resource_registry" />
             <argument type="service" id="sylius.translatable_entity_locale_assigner" />
-            <tag name="doctrine.event_listener" connection="default" event="loadClassMetadata" priority="99" />
-            <tag name="doctrine.event_listener" connection="default" event="postLoad" priority="99" />
+            <tag name="doctrine.event_subscriber" connection="default" priority="99" />
         </service>
         <service id="Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener" alias="sylius.translation.translatable_listener.doctrine.orm" />
 

src/Component/src/Doctrine/Persistence/RepositoryInterface.php

@@ -18,7 +18,6 @@
 
 /**
  * @template T of ResourceInterface
- *
  * @extends ObjectRepository<T>
  */
 interface RepositoryInterface extends ObjectRepository

src/Component/src/Metadata/MetadataInterface.php

@@ -30,9 +30,6 @@ public function getPluralName(): string;
 
     public function getDriver(): string|false;
 
-    /**
-     * @return ?string
-     */
     public function getTemplatesNamespace(): ?string;
 
     /**

src/Component/src/Model/ToggleableInterface.php

@@ -22,9 +22,6 @@ interface ToggleableInterface
      */
     public function isEnabled();
 
-    /**
-     * @param bool $enabled
-     */
     public function setEnabled(?bool $enabled): void;
 
     public function enable(): void;

src/Component/src/Model/ToggleableTrait.php

@@ -23,9 +23,6 @@ public function isEnabled(): bool
         return $this->enabled;
     }
 
-    /**
-     * @param bool $enabled
-     */
     public function setEnabled(?bool $enabled): void
     {
         $this->enabled = (bool) $enabled;