Add metadata mutators

loic425 · loic425 · commit 1c3c84166fea · 2025-10-30T11:26:17.000+01:00
diff --git a/phpstan.neon b/phpstan.neon
@@ -86,6 +86,7 @@ parameters:
         - '/Trying to invoke mixed/'
         - '/Method Sylius\\Bundle\\ResourceBundle\\Grid\\Controller\\ResourcesResolver\:\:getResources\(\) has no return type specified\./'
         - '/Parameter \#2 \$callback of function preg_replace_callback expects callable\(array\<int\|string\, string\>\): string, Closure\(array\)\: mixed given\./'
+        - '/Parameter #2 \$configurator of method Symfony\\Component\\DependencyInjection\\ContainerBuilder::registerAttributeForAutoconfiguration\(\)/'
         - '/Parameter \#1 \$objectOrArray of method Symfony\\Component\\PropertyAccess\\PropertyAccessorInterface\:\:getValue\(\) expects array\|object, array\|object\|null given\./'
         - '/Parameter \#1 \$min \(0\) of function random_int expects lower number than parameter \#2 \$max \(int\<\-1, max\>\)\./'
         - '/Method Sylius\\Resource\\Model\\ResourceInterface\:\:getId\(\) has no return type specified\./'
diff --git a/psalm.xml b/psalm.xml
@@ -39,6 +39,7 @@
                 <referencedFunction name="Doctrine\Persistence\ObjectManager::getClassMetadata" />
                 <referencedFunction name="ReflectionClass::getAttributes" />
                 <file name="src/Bundle/Form/DataTransformer/CollectionToStringTransformer.php" />
+                <file name="src/Bundle/DependencyInjection/SyliusResourceExtension.php" />
                 <file name="src/Component/src/Doctrine/Persistence/InMemoryRepository.php" />
                 <file name="src/Component/src/Symfony/Request/State/Provider.php" />
             </errorLevel>
@@ -153,6 +154,12 @@
             </errorLevel>
         </MissingClassConstType>
 
+        <MissingConstructor>
+            <errorLevel type="suppress">
+                <file name="src/Component/src/Metadata/Mutator/ResourceMutatorCollection.php" />
+            </errorLevel>
+        </MissingConstructor>
+
         <MissingParamType>
             <errorLevel type="suppress">
                 <file name="src/Bundle/Routing/ResourceLoader.php" />
diff --git a/src/Bundle/DependencyInjection/SyliusResourceExtension.php b/src/Bundle/DependencyInjection/SyliusResourceExtension.php
@@ -23,9 +23,13 @@
 use Sylius\Component\Resource\Factory\FactoryInterface as LegacyFactoryInterface;
 use Sylius\Resource\Factory\Factory;
 use Sylius\Resource\Factory\FactoryInterface;
+use Sylius\Resource\Metadata\AsOperationMutator;
 use Sylius\Resource\Metadata\AsResource;
+use Sylius\Resource\Metadata\AsResourceMutator;
 use Sylius\Resource\Metadata\Metadata;
+use Sylius\Resource\Metadata\OperationMutatorInterface;
 use Sylius\Resource\Metadata\ResourceMetadata;
+use Sylius\Resource\Metadata\ResourceMutatorInterface;
 use Sylius\Resource\Reflection\ClassReflection;
 use Sylius\Resource\State\ProcessorInterface;
 use Sylius\Resource\State\ProviderInterface;
@@ -34,6 +38,7 @@
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\Config\Loader\LoaderInterface;
 use Symfony\Component\Config\Resource\DirectoryResource;
+use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
 use Symfony\Component\DependencyInjection\Exception\RuntimeException;
@@ -76,6 +81,36 @@ public function load(array $configs, ContainerBuilder $container): void
         $this->loadPersistence($config['drivers'], $config['resources'], $loader, $container);
         $this->loadResources($config['resources'], $container);
 
+        $container->registerAttributeForAutoconfiguration(
+            AsResourceMutator::class,
+            static function (ChildDefinition $definition, AsResourceMutator $attribute, \Reflector $reflector): void {
+                if (!$reflector instanceof \ReflectionClass) {
+                    return;
+                }
+
+                if (!is_a($reflector->name, ResourceMutatorInterface::class, true)) {
+                    throw new RuntimeException(\sprintf('Resource mutator "%s" should implement %s', $reflector->name, ResourceMutatorInterface::class));
+                }
+
+                $definition->addTag('sylius.resource_mutator', [
+                    'resourceClass' => $attribute->resourceClass,
+                ]);
+            },
+        );
+
+        $container->registerAttributeForAutoconfiguration(
+            AsOperationMutator::class,
+            static function (ChildDefinition $definition, AsOperationMutator $attribute, \ReflectionClass $reflector): void {
+                if (!is_a($reflector->name, OperationMutatorInterface::class, true)) {
+                    throw new RuntimeException(\sprintf('Operation mutator "%s" should implement %s', $reflector->name, OperationMutatorInterface::class));
+                }
+
+                $definition->addTag('sylius.operation_mutator', [
+                    'operationName' => $attribute->operationName,
+                ]);
+            },
+        );
+
         $container->registerForAutoconfiguration(ProviderInterface::class)
             ->addTag('sylius.state_provider')
         ;
diff --git a/src/Bundle/Resources/config/services/metadata/extractor.xml b/src/Bundle/Resources/config/services/metadata/extractor.xml
@@ -1,3 +1,16 @@
+<?xml version="1.0" ?>
+
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Sylius Sp. z o.o.
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
     <services>
         <service id="sylius.metadata.resource_extractor.php_file" class="Sylius\Resource\Metadata\Extractor\PhpFileResourceExtractor" public="false">
diff --git a/src/Bundle/Resources/config/services/metadata/mutator.xml b/src/Bundle/Resources/config/services/metadata/mutator.xml
@@ -0,0 +1,23 @@
+<?xml version="1.0" ?>
+
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Sylius Sp. z o.o.
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
+<container xmlns="http://symfony.com/schema/dic/services"
+           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+           xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
+
+    <services>
+        <service id="sylius.metadata.mutator_collection.resource" class="Sylius\Resource\Metadata\Mutator\ResourceMutatorCollection" public="false" />
+
+        <service id="sylius.metadata.mutator_collection.operation" class="Sylius\Resource\Metadata\Mutator\OperationMutatorCollection" public="false" />
+    </services>
+</container>
diff --git a/src/Bundle/Resources/config/services/metadata/resource_metadata_collection.xml b/src/Bundle/Resources/config/services/metadata/resource_metadata_collection.xml
@@ -36,6 +36,15 @@
             <argument type="service" id=".inner" />
         </service>
 
+        <service id="sylius.metadata.resource.metadata_collection_factory.mutator"
+                 class="Sylius\Resource\Metadata\Resource\Factory\MutatorResourceMetadataCollectionFactory"
+                 decorates="sylius.resource_metadata_collection.factory"
+                 decoration-priority="400">
+            <argument type="service" id="sylius.metadata.mutator_collection.resource" />
+            <argument type="service" id="sylius.metadata.mutator_collection.operation" />
+            <argument type="service" id=".inner" />
+        </service>
+
         <service id="sylius.resource_metadata_collection.factory.state_machine"
                  class="Sylius\Resource\Metadata\Resource\Factory\StateMachineResourceMetadataCollectionFactory"
                  decorates="sylius.resource_metadata_collection.factory"
diff --git a/src/Bundle/SyliusResourceBundle.php b/src/Bundle/SyliusResourceBundle.php
@@ -31,6 +31,7 @@
 use Sylius\Bundle\ResourceBundle\DependencyInjection\PagerfantaExtension;
 use Sylius\Resource\Symfony\DependencyInjection\Compiler\DisableMetadataCachePass;
 use Sylius\Resource\Symfony\DependencyInjection\Compiler\FallbackToKernelDefaultLocalePass;
+use Sylius\Resource\Symfony\DependencyInjection\Compiler\MetadataMutatorPass;
 use Symfony\Component\DependencyInjection\Compiler\PassConfig;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
@@ -54,6 +55,7 @@ public function build(ContainerBuilder $container): void
         $container->addCompilerPass(new FallbackToKernelDefaultLocalePass());
         $container->addCompilerPass(new DoctrineContainerRepositoryFactoryPass());
         $container->addCompilerPass(new DoctrineTargetEntitiesResolverPass(new TargetEntitiesResolver()), PassConfig::TYPE_BEFORE_OPTIMIZATION, 1);
+        $container->addCompilerPass(new MetadataMutatorPass());
         $container->addCompilerPass(new RegisterFormBuilderPass());
         $container->addCompilerPass(new RegisterFqcnControllersPass());
         $container->addCompilerPass(new RegisterResourceRepositoryPass());
diff --git a/src/Component/src/Metadata/AsOperationMutator.php b/src/Component/src/Metadata/AsOperationMutator.php
@@ -0,0 +1,23 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Metadata;
+
+#[\Attribute(\Attribute::TARGET_CLASS)]
+class AsOperationMutator
+{
+    public function __construct(
+        public readonly string $operationName,
+    ) {
+    }
+}
diff --git a/src/Component/src/Metadata/AsResourceMutator.php b/src/Component/src/Metadata/AsResourceMutator.php
@@ -0,0 +1,26 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Metadata;
+
+#[\Attribute(\Attribute::TARGET_CLASS)]
+class AsResourceMutator
+{
+    /**
+     * @param class-string $resourceClass
+     */
+    public function __construct(
+        public readonly string $resourceClass,
+    ) {
+    }
+}
diff --git a/src/Component/src/Metadata/Mutator/OperationMutatorCollection.php b/src/Component/src/Metadata/Mutator/OperationMutatorCollection.php
@@ -0,0 +1,42 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Metadata\Mutator;
+
+use Sylius\Resource\Metadata\OperationMutatorInterface;
+
+/**
+ * @internal
+ */
+final class OperationMutatorCollection implements OperationMutatorCollectionInterface
+{
+    private array $mutators = [];
+
+    /**
+     * Adds a mutator to the container for a given operation name.
+     */
+    public function add(string $operationName, OperationMutatorInterface $mutator): void
+    {
+        $this->mutators[$operationName][] = $mutator;
+    }
+
+    public function get(string $id): array
+    {
+        return $this->mutators[$id] ?? [];
+    }
+
+    public function has(string $id): bool
+    {
+        return isset($this->mutators[$id]);
+    }
+}
diff --git a/src/Component/src/Metadata/Mutator/OperationMutatorCollectionInterface.php b/src/Component/src/Metadata/Mutator/OperationMutatorCollectionInterface.php
@@ -0,0 +1,28 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Metadata\Mutator;
+
+use Psr\Container\ContainerInterface;
+use Sylius\Resource\Metadata\OperationMutatorInterface;
+
+/**
+ * Collection of Operation mutators to mutate Operation metadata.
+ */
+interface OperationMutatorCollectionInterface extends ContainerInterface
+{
+    /**
+     * @return list<OperationMutatorInterface>
+     */
+    public function get(string $id): mixed;
+}
diff --git a/src/Component/src/Metadata/Mutator/ResourceMutatorCollection.php b/src/Component/src/Metadata/Mutator/ResourceMutatorCollection.php
@@ -0,0 +1,39 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Metadata\Mutator;
+
+use Sylius\Resource\Metadata\ResourceMutatorInterface;
+
+/**
+ * @internal
+ */
+final class ResourceMutatorCollection implements ResourceMutatorCollectionInterface
+{
+    private array $mutators = [];
+
+    public function add(string $resourceClass, ResourceMutatorInterface $mutator): void
+    {
+        $this->mutators[$resourceClass][] = $mutator;
+    }
+
+    public function get(string $id): array
+    {
+        return $this->mutators[$id] ?? [];
+    }
+
+    public function has(string $id): bool
+    {
+        return isset($this->mutators[$id]);
+    }
+}
diff --git a/src/Component/src/Metadata/Mutator/ResourceMutatorCollectionInterface.php b/src/Component/src/Metadata/Mutator/ResourceMutatorCollectionInterface.php
@@ -0,0 +1,28 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Metadata\Mutator;
+
+use Psr\Container\ContainerInterface;
+use Sylius\Resource\Metadata\ResourceMutatorInterface;
+
+/**
+ * Collection of Resource mutators to mutate ResourceMetadata.
+ */
+interface ResourceMutatorCollectionInterface extends ContainerInterface
+{
+    /**
+     * @return list<ResourceMutatorInterface>
+     */
+    public function get(string $id): array;
+}
diff --git a/src/Component/src/Metadata/OperationMutatorInterface.php b/src/Component/src/Metadata/OperationMutatorInterface.php
@@ -0,0 +1,19 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Metadata;
+
+interface OperationMutatorInterface
+{
+    public function __invoke(Operation $operation): Operation;
+}
diff --git a/src/Component/src/Metadata/Operations.php b/src/Component/src/Metadata/Operations.php
@@ -17,13 +17,15 @@
 
 /**
  * @internal
+ *
+ * @template-covariant T of Operation
  */
 final class Operations implements \IteratorAggregate, \Countable
 {
     private array $operations = [];
 
     /**
-     * @param array<string|int, Operation> $operations
+     * @param array<string|int, T> $operations
      */
     public function __construct(array $operations = [])
     {
@@ -32,6 +34,9 @@ public function __construct(array $operations = [])
         }
     }
 
+    /**
+     * @return \Iterator<string, T>
+     */
     public function getIterator(): \Traversable
     {
         return (function (): \Generator {
diff --git a/src/Component/src/Metadata/Resource/Factory/MutatorResourceMetadataCollectionFactory.php b/src/Component/src/Metadata/Resource/Factory/MutatorResourceMetadataCollectionFactory.php
diff --git a/src/Component/src/Metadata/ResourceMutatorInterface.php b/src/Component/src/Metadata/ResourceMutatorInterface.php
diff --git a/src/Component/src/Symfony/DependencyInjection/Compiler/MetadataMutatorPass.php b/src/Component/src/Symfony/DependencyInjection/Compiler/MetadataMutatorPass.php
diff --git a/src/Component/tests/Metadata/Resource/Factory/MutatorResourceMetadataCollectionFactoryTest.php b/src/Component/tests/Metadata/Resource/Factory/MutatorResourceMetadataCollectionFactoryTest.php
diff --git a/tests/Application/src/BoardGameBlog/Infrastructure/Sylius/Resource/BoardGameResource.php b/tests/Application/src/BoardGameBlog/Infrastructure/Sylius/Resource/BoardGameResource.php
diff --git a/tests/Application/src/BoardGameBlog/Infrastructure/Sylius/Resource/Mutator/BoardGameTemplatesDirMutator.php b/tests/Application/src/BoardGameBlog/Infrastructure/Sylius/Resource/Mutator/BoardGameTemplatesDirMutator.php
diff --git a/tests/Application/src/BoardGameBlog/Infrastructure/Sylius/Resource/Mutator/CreateBoardGameProcessorMutator.php b/tests/Application/src/BoardGameBlog/Infrastructure/Sylius/Resource/Mutator/CreateBoardGameProcessorMutator.php
