Move some namespaces on Exceptions

loic425 · loic425 · commit 2a616790ce9b · 2024-04-09T17:48:54.000+02:00
diff --git a/src/Bundle/Controller/ResourceController.php b/src/Bundle/Controller/ResourceController.php
@@ -16,9 +16,9 @@
 use Doctrine\Persistence\ObjectManager;
 use FOS\RestBundle\View\View;
 use Sylius\Bundle\ResourceBundle\Event\ResourceControllerEvent;
-use Sylius\Component\Resource\Exception\DeleteHandlingException;
-use Sylius\Component\Resource\Exception\UpdateHandlingException;
 use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
+use Sylius\Resource\Exception\DeleteHandlingException;
+use Sylius\Resource\Exception\UpdateHandlingException;
 use Sylius\Resource\Factory\FactoryInterface;
 use Sylius\Resource\Metadata\MetadataInterface;
 use Sylius\Resource\Model\ResourceInterface;
diff --git a/src/Bundle/Form/EventSubscriber/AddCodeFormSubscriber.php b/src/Bundle/Form/EventSubscriber/AddCodeFormSubscriber.php
@@ -13,7 +13,7 @@
 
 namespace Sylius\Bundle\ResourceBundle\Form\EventSubscriber;
 
-use Sylius\Component\Resource\Exception\UnexpectedTypeException;
+use Sylius\Resource\Exception\UnexpectedTypeException;
 use Sylius\Resource\Model\CodeAwareInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
diff --git a/src/Bundle/spec/Controller/ResourceControllerSpec.php b/src/Bundle/spec/Controller/ResourceControllerSpec.php
@@ -33,8 +33,8 @@
 use Sylius\Bundle\ResourceBundle\Controller\StateMachineInterface;
 use Sylius\Bundle\ResourceBundle\Controller\ViewHandlerInterface;
 use Sylius\Bundle\ResourceBundle\Event\ResourceControllerEvent;
-use Sylius\Component\Resource\Exception\DeleteHandlingException;
 use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
+use Sylius\Resource\Exception\DeleteHandlingException;
 use Sylius\Resource\Factory\FactoryInterface;
 use Sylius\Resource\Metadata\MetadataInterface;
 use Sylius\Resource\Model\ResourceInterface;
diff --git a/src/Bundle/spec/Form/EventSubscriber/AddCodeFormSubscriberSpec.php b/src/Bundle/spec/Form/EventSubscriber/AddCodeFormSubscriberSpec.php
@@ -15,7 +15,7 @@
 
 use PhpSpec\ObjectBehavior;
 use Prophecy\Argument;
-use Sylius\Component\Resource\Exception\UnexpectedTypeException;
+use Sylius\Resource\Exception\UnexpectedTypeException;
 use Sylius\Resource\Model\CodeAwareInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Form\Extension\Core\Type\FormType;
diff --git a/src/Component/legacy/spec/Exception/RaceConditionExceptionSpec.php b/src/Component/legacy/spec/Exception/RaceConditionExceptionSpec.php
@@ -14,7 +14,7 @@
 namespace spec\Sylius\Component\Resource\Exception;
 
 use PhpSpec\ObjectBehavior;
-use Sylius\Component\Resource\Exception\UpdateHandlingException;
+use Sylius\Resource\Exception\UpdateHandlingException;
 
 final class RaceConditionExceptionSpec extends ObjectBehavior
 {
diff --git a/src/Component/legacy/src/Exception/DeleteHandlingException.php b/src/Component/legacy/src/Exception/DeleteHandlingException.php
@@ -13,32 +13,10 @@
 
 namespace Sylius\Component\Resource\Exception;
 
-class DeleteHandlingException extends \Exception
-{
-    protected string $flash;
+class_exists(\Sylius\Resource\Exception\DeleteHandlingException::class);
 
-    protected int $apiResponseCode;
-
-    public function __construct(
-        string $message = 'Ups, something went wrong during deleting a resource, please try again.',
-        string $flash = 'something_went_wrong_error',
-        int $apiResponseCode = 500,
-        int $code = 0,
-        ?\Exception $previous = null,
-    ) {
-        parent::__construct($message, $code, $previous);
-
-        $this->flash = $flash;
-        $this->apiResponseCode = $apiResponseCode;
-    }
-
-    public function getFlash(): string
-    {
-        return $this->flash;
-    }
-
-    public function getApiResponseCode(): int
+if (false) {
+    class DeleteHandlingException extends \Sylius\Resource\Exception\DeleteHandlingException
     {
-        return $this->apiResponseCode;
     }
 }
diff --git a/src/Component/legacy/src/Exception/RaceConditionException.php b/src/Component/legacy/src/Exception/RaceConditionException.php
@@ -13,16 +13,10 @@
 
 namespace Sylius\Component\Resource\Exception;
 
-class RaceConditionException extends UpdateHandlingException
-{
-    public function __construct(?\Exception $previous = null)
+class_exists(\Sylius\Resource\Exception\RaceConditionException::class);
+
+if (false) {
+    class RaceConditionException extends \Sylius\Resource\Exception\RaceConditionException
     {
-        parent::__construct(
-            'Operated entity was previously modified.',
-            'race_condition_error',
-            409,
-            null !== $previous ? (int) $previous->getCode() : 0,
-            $previous,
-        );
     }
 }
diff --git a/src/Component/legacy/src/Exception/UnexpectedTypeException.php b/src/Component/legacy/src/Exception/UnexpectedTypeException.php
@@ -13,17 +13,10 @@
 
 namespace Sylius\Component\Resource\Exception;
 
-class UnexpectedTypeException extends \InvalidArgumentException
-{
-    /**
-     * @param mixed $value
-     */
-    public function __construct($value, string $expectedType)
+class_exists(\Sylius\Resource\Exception\UnexpectedTypeException::class);
+
+if (false) {
+    class UnexpectedTypeException extends \Sylius\Resource\Exception\UnexpectedTypeException
     {
-        parent::__construct(sprintf(
-            'Expected argument of type "%s", "%s" given.',
-            $expectedType,
-            is_object($value) ? get_class($value) : gettype($value),
-        ));
     }
 }
diff --git a/src/Component/legacy/src/Exception/UnsupportedMethodException.php b/src/Component/legacy/src/Exception/UnsupportedMethodException.php
@@ -13,13 +13,10 @@
 
 namespace Sylius\Component\Resource\Exception;
 
-class UnsupportedMethodException extends \Exception
-{
-    public function __construct(string $methodName)
+class_exists(\Sylius\Resource\Exception\UnsupportedMethodException::class);
+
+if (false) {
+    class UnsupportedMethodException extends \Sylius\Resource\Exception\UnsupportedMethodException
     {
-        parent::__construct(sprintf(
-            'The method "%s" is not supported.',
-            $methodName,
-        ));
     }
 }
diff --git a/src/Component/legacy/src/Exception/UpdateHandlingException.php b/src/Component/legacy/src/Exception/UpdateHandlingException.php
@@ -13,32 +13,10 @@
 
 namespace Sylius\Component\Resource\Exception;
 
-class UpdateHandlingException extends \Exception
-{
-    protected string $flash;
+class_exists(\Sylius\Resource\Exception\UpdateHandlingException::class);
 
-    protected int $apiResponseCode;
-
-    public function __construct(
-        string $message = 'Ups, something went wrong during updating a resource, please try again.',
-        string $flash = 'something_went_wrong_error',
-        int $apiResponseCode = 400,
-        int $code = 0,
-        ?\Exception $previous = null,
-    ) {
-        parent::__construct($message, $code, $previous);
-
-        $this->flash = $flash;
-        $this->apiResponseCode = $apiResponseCode;
-    }
-
-    public function getFlash(): string
-    {
-        return $this->flash;
-    }
-
-    public function getApiResponseCode(): int
+if (false) {
+    class UpdateHandlingException extends \Sylius\Resource\Exception\UpdateHandlingException
     {
-        return $this->apiResponseCode;
     }
 }
diff --git a/src/Component/legacy/src/Exception/VariantWithNoOptionsValuesException.php b/src/Component/legacy/src/Exception/VariantWithNoOptionsValuesException.php
@@ -13,10 +13,10 @@
 
 namespace Sylius\Component\Resource\Exception;
 
-final class VariantWithNoOptionsValuesException extends \Exception
-{
-    public function __construct()
+class_exists(\Sylius\Resource\Exception\VariantWithNoOptionsValuesException::class);
+
+if (false) {
+    final class VariantWithNoOptionsValuesException extends \Sylius\Resource\Exception\VariantWithNoOptionsValuesException
     {
-        parent::__construct('sylius.product_variant.cannot_generate_variants');
     }
 }
diff --git a/src/Component/spec/Doctrine/Persistence/InMemoryRepositorySpec.php b/src/Component/spec/Doctrine/Persistence/InMemoryRepositorySpec.php
@@ -16,9 +16,9 @@
 use Pagerfanta\Pagerfanta;
 use PhpSpec\ObjectBehavior;
 use spec\Sylius\Component\Resource\Fixtures\SampleBookResourceInterface;
-use Sylius\Component\Resource\Exception\UnexpectedTypeException;
 use Sylius\Resource\Doctrine\Persistence\Exception\ResourceExistsException;
 use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
+use Sylius\Resource\Exception\UnexpectedTypeException;
 use Sylius\Resource\Model\ResourceInterface;
 
 require_once dirname(__DIR__, 3) . '/legacy/spec/Fixtures/SampleBookResourceInterface.php';
diff --git a/src/Component/spec/Factory/TranslatableFactorySpec.php b/src/Component/spec/Factory/TranslatableFactorySpec.php
diff --git a/src/Component/src/Exception/DeleteHandlingException.php b/src/Component/src/Exception/DeleteHandlingException.php
@@ -0,0 +1,46 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Exception;
+
+class DeleteHandlingException extends \Exception
+{
+    protected string $flash;
+
+    protected int $apiResponseCode;
+
+    public function __construct(
+        string $message = 'Ups, something went wrong during deleting a resource, please try again.',
+        string $flash = 'something_went_wrong_error',
+        int $apiResponseCode = 500,
+        int $code = 0,
+        ?\Exception $previous = null,
+    ) {
+        parent::__construct($message, $code, $previous);
+
+        $this->flash = $flash;
+        $this->apiResponseCode = $apiResponseCode;
+    }
+
+    public function getFlash(): string
+    {
+        return $this->flash;
+    }
+
+    public function getApiResponseCode(): int
+    {
+        return $this->apiResponseCode;
+    }
+}
+
+class_alias(DeleteHandlingException::class, \Sylius\Component\Resource\Exception\DeleteHandlingException::class);
diff --git a/src/Component/src/Exception/RaceConditionException.php b/src/Component/src/Exception/RaceConditionException.php
@@ -0,0 +1,30 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Exception;
+
+class RaceConditionException extends UpdateHandlingException
+{
+    public function __construct(?\Exception $previous = null)
+    {
+        parent::__construct(
+            'Operated entity was previously modified.',
+            'race_condition_error',
+            409,
+            null !== $previous ? (int) $previous->getCode() : 0,
+            $previous,
+        );
+    }
+}
+
+class_alias(RaceConditionException::class, \Sylius\Component\Resource\Exception\RaceConditionException::class);
diff --git a/src/Component/src/Exception/UnexpectedTypeException.php b/src/Component/src/Exception/UnexpectedTypeException.php
@@ -0,0 +1,31 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Exception;
+
+class UnexpectedTypeException extends \InvalidArgumentException
+{
+    /**
+     * @param mixed $value
+     */
+    public function __construct($value, string $expectedType)
+    {
+        parent::__construct(sprintf(
+            'Expected argument of type "%s", "%s" given.',
+            $expectedType,
+            is_object($value) ? get_class($value) : gettype($value),
+        ));
+    }
+}
+
+class_alias(UnexpectedTypeException::class, \Sylius\Component\Resource\Exception\UnexpectedTypeException::class);
diff --git a/src/Component/src/Exception/UnsupportedMethodException.php b/src/Component/src/Exception/UnsupportedMethodException.php
@@ -0,0 +1,27 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Exception;
+
+class UnsupportedMethodException extends \Exception
+{
+    public function __construct(string $methodName)
+    {
+        parent::__construct(sprintf(
+            'The method "%s" is not supported.',
+            $methodName,
+        ));
+    }
+}
+
+class_alias(UnsupportedMethodException::class, \Sylius\Component\Resource\Exception\UnsupportedMethodException::class);
diff --git a/src/Component/src/Exception/UpdateHandlingException.php b/src/Component/src/Exception/UpdateHandlingException.php
@@ -0,0 +1,46 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Sylius Sp. z o.o.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Sylius\Resource\Exception;
+
+class UpdateHandlingException extends \Exception
+{
+    protected string $flash;
+
+    protected int $apiResponseCode;
+
+    public function __construct(
+        string $message = 'Ups, something went wrong during updating a resource, please try again.',
+        string $flash = 'something_went_wrong_error',
+        int $apiResponseCode = 400,
+        int $code = 0,
+        ?\Exception $previous = null,
+    ) {
+        parent::__construct($message, $code, $previous);
+
+        $this->flash = $flash;
+        $this->apiResponseCode = $apiResponseCode;
+    }
+
+    public function getFlash(): string
+    {
+        return $this->flash;
+    }
+
+    public function getApiResponseCode(): int
+    {
+        return $this->apiResponseCode;
+    }
+}
+
+class_alias(UpdateHandlingException::class, \Sylius\Component\Resource\Exception\UpdateHandlingException::class);
diff --git a/src/Component/src/Exception/VariantWithNoOptionsValuesException.php b/src/Component/src/Exception/VariantWithNoOptionsValuesException.php
diff --git a/src/Component/src/Factory/TranslatableFactory.php b/src/Component/src/Factory/TranslatableFactory.php
diff --git a/tests/Application/src/Factory/BookFactory.php b/tests/Application/src/Factory/BookFactory.php

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`namespace spec\Sylius\Component\Resource\Exception;`
`15`	`15`
`16`	`16`	`use PhpSpec\ObjectBehavior;`
`17`		`-use Sylius\Component\Resource\Exception\UpdateHandlingException;`
	`17`	`+use Sylius\Resource\Exception\UpdateHandlingException;`
`18`	`18`
`19`	`19`	`final class RaceConditionExceptionSpec extends ObjectBehavior`
`20`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,16 +13,10 @@`
`13`	`13`
`14`	`14`	`namespace Sylius\Component\Resource\Exception;`
`15`	`15`
`16`		`-class RaceConditionException extends UpdateHandlingException`
`17`		`-{`
`18`		`- public function __construct(?\Exception $previous = null)`
	`16`	`+class_exists(\Sylius\Resource\Exception\RaceConditionException::class);`
	`17`	`+`
	`18`	`+if (false) {`
	`19`	`+ class RaceConditionException extends \Sylius\Resource\Exception\RaceConditionException`
`19`	`20`	`{`
`20`		`- parent::__construct(`
`21`		`- 'Operated entity was previously modified.',`
`22`		`- 'race_condition_error',`
`23`		`- 409,`
`24`		`- null !== $previous ? (int) $previous->getCode() : 0,`
`25`		`- $previous,`
`26`		`- );`
`27`	`21`	`}`
`28`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,13 +13,10 @@`
`13`	`13`
`14`	`14`	`namespace Sylius\Component\Resource\Exception;`
`15`	`15`
`16`		`-class UnsupportedMethodException extends \Exception`
`17`		`-{`
`18`		`- public function __construct(string $methodName)`
	`16`	`+class_exists(\Sylius\Resource\Exception\UnsupportedMethodException::class);`
	`17`	`+`
	`18`	`+if (false) {`
	`19`	`+ class UnsupportedMethodException extends \Sylius\Resource\Exception\UnsupportedMethodException`
`19`	`20`	`{`
`20`		`- parent::__construct(sprintf(`
`21`		`- 'The method "%s" is not supported.',`
`22`		`- $methodName,`
`23`		`- ));`
`24`	`21`	`}`
`25`	`22`	`}`