refactor #768 Move some namespaces on Exceptions (loic425)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT


Commits
-------

2a61679 Move some namespaces on Exceptions
bfa6df9 Fix Psam errors
165873a Fix PHPStan errors
16cdabb Remove translatable factory spec
109800f Move spec file
b96ee2b Test the alias
cc473c0 Add InvalidArgumentException & Exception
e945ee9 Test the aliases

Author: lchrusciel

phpstan.neon

@@ -25,6 +25,7 @@ parameters:
         - %currentWorkingDirectory%/src/Bundle/Tests/*
         - %currentWorkingDirectory%/src/Component/legacy/spec/*
         - %currentWorkingDirectory%/src/Component/legacy/src/Annotation/*
+        - %currentWorkingDirectory%/src/Component/legacy/src/Exception/*
         - %currentWorkingDirectory%/src/Component/legacy/src/Factory/*
         - %currentWorkingDirectory%/src/Component/legacy/src/Generator/*
         - %currentWorkingDirectory%/src/Component/legacy/src/Metadata/*

psalm.xml

@@ -227,6 +227,7 @@
         <TypeDoesNotContainType>
             <errorLevel type="suppress">
                 <directory name="src/Component/legacy/src/Annotation" />
+                <directory name="src/Component/legacy/src/Exception" />
                 <directory name="src/Component/legacy/src/Factory" />
                 <directory name="src/Component/legacy/src/Generator" />
                 <directory name="src/Component/legacy/src/Metadata" />

src/Bundle/Controller/ResourceController.php

@@ -16,9 +16,9 @@
 use Doctrine\Persistence\ObjectManager;
 use FOS\RestBundle\View\View;
 use Sylius\Bundle\ResourceBundle\Event\ResourceControllerEvent;
-use Sylius\Component\Resource\Exception\DeleteHandlingException;
-use Sylius\Component\Resource\Exception\UpdateHandlingException;
 use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
+use Sylius\Resource\Exception\DeleteHandlingException;
+use Sylius\Resource\Exception\UpdateHandlingException;
 use Sylius\Resource\Factory\FactoryInterface;
 use Sylius\Resource\Metadata\MetadataInterface;
 use Sylius\Resource\Model\ResourceInterface;

src/Bundle/Form/EventSubscriber/AddCodeFormSubscriber.php

@@ -13,7 +13,7 @@
 
 namespace Sylius\Bundle\ResourceBundle\Form\EventSubscriber;
 
-use Sylius\Component\Resource\Exception\UnexpectedTypeException;
+use Sylius\Resource\Exception\UnexpectedTypeException;
 use Sylius\Resource\Model\CodeAwareInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Form\Extension\Core\Type\TextType;

src/Bundle/spec/Controller/ResourceControllerSpec.php

@@ -33,8 +33,8 @@
 use Sylius\Bundle\ResourceBundle\Controller\StateMachineInterface;
 use Sylius\Bundle\ResourceBundle\Controller\ViewHandlerInterface;
 use Sylius\Bundle\ResourceBundle\Event\ResourceControllerEvent;
-use Sylius\Component\Resource\Exception\DeleteHandlingException;
 use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
+use Sylius\Resource\Exception\DeleteHandlingException;
 use Sylius\Resource\Factory\FactoryInterface;
 use Sylius\Resource\Metadata\MetadataInterface;
 use Sylius\Resource\Model\ResourceInterface;

src/Bundle/spec/Form/EventSubscriber/AddCodeFormSubscriberSpec.php

@@ -15,7 +15,7 @@
 
 use PhpSpec\ObjectBehavior;
 use Prophecy\Argument;
-use Sylius\Component\Resource\Exception\UnexpectedTypeException;
+use Sylius\Resource\Exception\UnexpectedTypeException;
 use Sylius\Resource\Model\CodeAwareInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\Form\Extension\Core\Type\FormType;

src/Component/legacy/spec/Exception/DeleteHandlingExceptionSpec.php

@@ -14,26 +14,12 @@
 namespace spec\Sylius\Component\Resource\Exception;
 
 use PhpSpec\ObjectBehavior;
+use Sylius\Resource\Exception\DeleteHandlingException as NewDeleteHandlingException;
 
 final class DeleteHandlingExceptionSpec extends ObjectBehavior
 {
-    function it_extends_an_exception(): void
+    function it_should_be_an_alias_of_delete_handling_exception(): void
     {
-        $this->shouldHaveType(\Exception::class);
-    }
-
-    function it_has_a_message(): void
-    {
-        $this->getMessage()->shouldReturn('Ups, something went wrong during deleting a resource, please try again.');
-    }
-
-    function it_has_a_flash(): void
-    {
-        $this->getFlash()->shouldReturn('something_went_wrong_error');
-    }
-
-    function it_has_an_api_response_code(): void
-    {
-        $this->getApiResponseCode()->shouldReturn(500);
+        $this->shouldBeAnInstanceOf(NewDeleteHandlingException::class);
     }
 }

src/Component/legacy/spec/Exception/RaceConditionExceptionSpec.php

@@ -14,27 +14,12 @@
 namespace spec\Sylius\Component\Resource\Exception;
 
 use PhpSpec\ObjectBehavior;
-use Sylius\Component\Resource\Exception\UpdateHandlingException;
+use Sylius\Resource\Exception\RaceConditionException as NewRaceConditionException;
 
 final class RaceConditionExceptionSpec extends ObjectBehavior
 {
-    function it_extends_an_update_handling_exception(): void
+    function it_should_be_an_alias_of_race_condition_exception(): void
     {
-        $this->shouldHaveType(UpdateHandlingException::class);
-    }
-
-    function it_has_a_message(): void
-    {
-        $this->getMessage()->shouldReturn('Operated entity was previously modified.');
-    }
-
-    function it_has_a_flash(): void
-    {
-        $this->getFlash()->shouldReturn('race_condition_error');
-    }
-
-    function it_has_an_api_response_code(): void
-    {
-        $this->getApiResponseCode()->shouldReturn(409);
+        $this->shouldBeAnInstanceOf(NewRaceConditionException::class);
     }
 }

src/Component/legacy/spec/Exception/UnexpectedTypeExceptionSpec.php

@@ -14,6 +14,7 @@
 namespace spec\Sylius\Component\Resource\Exception;
 
 use PhpSpec\ObjectBehavior;
+use Sylius\Resource\Exception\UnexpectedTypeException as NewUnexpectedTypeException;
 
 final class UnexpectedTypeExceptionSpec extends ObjectBehavior
 {
@@ -22,13 +23,8 @@ function let(): void
         $this->beConstructedWith('stringValue', '\ExpectedType');
     }
 
-    function it_extends_invalid_argument_exception(): void
+    function it_should_be_an_alias_of_unexpected_type_exception(): void
     {
-        $this->shouldHaveType(\InvalidArgumentException::class);
-    }
-
-    function it_has_a_message(): void
-    {
-        $this->getMessage()->shouldReturn('Expected argument of type "\ExpectedType", "string" given.');
+        $this->shouldBeAnInstanceOf(NewUnexpectedTypeException::class);
     }
 }

src/Component/legacy/spec/Exception/UnsupportedMethodExceptionSpec.php

@@ -14,6 +14,7 @@
 namespace spec\Sylius\Component\Resource\Exception;
 
 use PhpSpec\ObjectBehavior;
+use Sylius\Resource\Exception\UnsupportedMethodException as NewUnsupportedMethodException;
 
 final class UnsupportedMethodExceptionSpec extends ObjectBehavior
 {
@@ -22,13 +23,8 @@ function let(): void
         $this->beConstructedWith('methodName');
     }
 
-    function it_extends_exception(): void
+    function it_should_be_an_alias_of_unsupported_method_exception(): void
     {
-        $this->shouldHaveType(\Exception::class);
-    }
-
-    function it_has_a_message(): void
-    {
-        $this->getMessage()->shouldReturn('The method "methodName" is not supported.');
+        $this->shouldBeAnInstanceOf(NewUnsupportedMethodException::class);
     }
 }