[Fix] Do not dispatch a post write event when data is already a response

Author: loic425

src/Component/src/Metadata/ResourceMetadata.php

@@ -28,9 +28,9 @@ public function __construct(
         private ?string $pluralName = null,
         private ?string $applicationName = null,
         private ?string $identifier = null,
-        protected ?array $normalizationContext = null,
-        protected ?array $denormalizationContext = null,
-        protected ?array $validationContext = null,
+        private ?array $normalizationContext = null,
+        private ?array $denormalizationContext = null,
+        private ?array $validationContext = null,
         private ?string $class = null,
         private string|false|null $driver = null,
         private ?array $vars = null,

src/Component/src/Symfony/EventDispatcher/State/DispatchPostWriteEventProcessor.php

@@ -18,6 +18,7 @@
 use Sylius\Resource\State\ProcessorInterface;
 use Sylius\Resource\Symfony\EventDispatcher\OperationEventDispatcherInterface;
 use Sylius\Resource\Symfony\EventDispatcher\OperationEventHandlerInterface;
+use Symfony\Component\HttpFoundation\Response;
 
 /**
  * @experimental
@@ -38,6 +39,10 @@ public function process(mixed $data, Operation $operation, Context $context): mi
     {
         $data = $this->processor->process($data, $operation, $context);
 
+        if ($data instanceof Response) {
+            return $data;
+        }
+
         $operationEvent = $this->operationEventDispatcher->dispatchPostEvent($data, $operation, $context);
 
         $eventResponse = $this->eventHandler->handlePostProcessEvent(

src/Component/src/Symfony/ExpressionLanguage/ArgumentParser.php

@@ -25,7 +25,7 @@ final class ArgumentParser implements ArgumentParserInterface
     public function __construct(
         private readonly ExpressionLanguage $expressionLanguage,
         private readonly VariablesCollectionInterface $variablesCollection,
-        readonly ?iterable $providers = null,
+        ?iterable $providers = null,
     ) {
         foreach ($providers ?? [] as $provider) {
             Assert::isInstanceOf($provider, ExpressionFunctionProviderInterface::class);

src/Component/tests/Symfony/EventDispatcher/State/DispatchPostWriteEventProcessorTest.php

@@ -91,4 +91,25 @@ public function it_returns_post_event_response(): void
         $result = $this->dispatchPostWriteEventProcessor->process($data, $operation, $context);
         $this->assertEquals($response, $result);
     }
+
+    /** @test */
+    public function it_does_nothing_if_the_decorated_processor_returns_a_response(): void
+    {
+        $data = new \stdClass();
+
+        $operation = new Create(processor: '\App\Processor');
+        $context = new Context();
+
+        $response = new Response();
+
+        $this->processor->process($data, $operation, $context)->willReturn($response)->shouldBeCalled();
+
+        $postEvent = new OperationEvent();
+
+        $this->operationEventDispatcher->dispatchPostEvent($response, $operation, $context)->willReturn($postEvent)->shouldNotBeCalled();
+
+        $this->eventHandler->handlePostProcessEvent($postEvent, $context)->willReturn(null)->shouldNotBeCalled();
+
+        $this->dispatchPostWriteEventProcessor->process($data, $operation, $context);
+    }
 }