Merge branch '1.11' into 1.12

* 1.11:
  Apply suggestions from code review
  Apply code review suggestions
  Generate changelog for v1.11.1
  Update UPGRADE file for v1.11.1
  Fix coding standard
  Fix ORM translatable listener for Symfony 5
  Link to disabling chapter
  Fix processing data without provider
  Fix few things
  Fix static analysis
  [Docs] Disable providing data

Author: GSadee

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## CHANGELOG
 
+## v1.11.1 (2024-09-02)
+
+#### Details
+
+- [#917](https://github.com/Sylius/SyliusResourceBundle/issues/917) Quick Fix ORM translatable listener for Symfony 5 ([@loic425](https://github.com/loic425))
+
 ## v1.11.0 (2024-08-29)
 
 ## v1.11.0-RC.2 (2024-07-12)

UPGRADE.md

@@ -10,6 +10,11 @@ In preparation of removal, following dependencies were moved to optional require
 
 ## UPGRADE FOR `1.11.x`
 
+### FROM `1.11.0` to `1.11.1`
+
+The `Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener` service has become a Doctrine subscriber again 
+to fully support Symfony 5.
+
 ### FROM `1.10.x` to `1.11.x`
 
 We remove the default mapping paths which are used to read PHP 8 attributes to build routes.

docs/processors.md

@@ -69,8 +69,11 @@ Use this processor on your operation.
 namespace App\Entity\Customer;
 
 use App\Sylius\State\Processor\CreateCustomerProcessor;
+use Sylius\Resource\Metadata\AsResource;
+use Sylius\Resource\Metadata\Create;
+use Sylius\Resource\Model\ResourceInterface;
 
-#[Resource]
+#[AsResource]
 #[Create(processor: CreateCustomerProcessor::class)]
 final class BoardGameResource implements ResourceInterface
 ```
@@ -109,7 +112,11 @@ Use this processor on your operation.
 
 namespace App\BoardGameBlog\Infrastructure\Sylius\Resource;
 
-#[Resource(
+use Sylius\Resource\Metadata\AsResource;
+use Sylius\Resource\Metadata\Delete;
+use Sylius\Resource\Model\ResourceInterface;
+
+#[AsResource(
     alias: 'app.board_game',
     section: 'admin',
     formType: BoardGameType::class,
@@ -120,6 +127,9 @@ namespace App\BoardGameBlog\Infrastructure\Sylius\Resource;
 final class BoardGameResource implements ResourceInterface
 ```
 
+Note that in a delete operation, you can disable providing data.
+See [Disable providing data](providers.md#disable-providing-data) chapter.
+
 **[Go back to the documentation's index](index.md)**
 
 **[> Next chapter: Responders](responders.md)**

docs/providers.md

@@ -7,6 +7,7 @@ Providers retrieve data from your persistence layer.
   * [Custom repository method](#custom-repository-method)
   * [Custom repository arguments](#custom-repository-arguments)
 * [Custom providers](#custom-providers)
+* [Disable providing data](#disable-providing-data)
 <!-- TOC -->
 
 ## Default providers
@@ -34,7 +35,11 @@ declare(strict_types=1);
 
 namespace App\Entity;
 
-#[Resource]
+use Sylius\Resource\Metadata\AsResource;
+use Sylius\Resource\Metadata\Show;
+use Sylius\Resource\Model\ResourceInterface;
+
+#[AsResource]
 #[Show(repositoryMethod: 'findOneByEmail')]
 final class Customer implements ResourceInterface
 {
@@ -61,7 +66,11 @@ declare(strict_types=1);
 
 namespace App\Entity;
 
-#[Resource]
+use Sylius\Resource\Metadata\AsResource;
+use Sylius\Resource\Metadata\Show;
+use Sylius\Resource\Model\ResourceInterface;
+
+#[AsResource]
 #[Show(repositoryMethod: 'findOneByEmail', repositoryArguments: ['email' => "request.attributes.get('email')"])]
 final class Customer implements ResourceInterface
 {
@@ -115,15 +124,84 @@ declare(strict_types=1);
 namespace App\BoardGameBlog\Infrastructure\Sylius\Resource;
 
 use App\BoardGameBlog\Infrastructure\Sylius\State\Provider\BoardGameItemProvider;
+use Sylius\Resource\Metadata\AsResource;
+use Sylius\Resource\Metadata\Show;
+use Sylius\Resource\Model\ResourceInterface;
 
-#[Resource]
+#[AsResource]
 #[Show(provider: BoardGameItemProvider::class)]
 final class BoardGameResource implements ResourceInterface
 {
     // [...]
 }
 ```
 
+## Disable providing data
+
+In some cases, you may want not to read data.
+
+For example, in a delete operation, you can implement your custom delete processor without reading it before.
+
+```php
+// src/BoardGameBlog/Infrastructure/Sylius/Resource/BoardGameResource.php
+
+declare(strict_types=1);
+
+namespace App\BoardGameBlog\Infrastructure\Sylius\Resource;
+
+use App\BoardgameBlog\Infrastructure\Sylius\State\Provider\DeleteBoardGameProcessor;
+use Sylius\Resource\Metadata\AsResource;
+use Sylius\Resource\Metadata\Delete;
+use Sylius\Resource\Model\ResourceInterface;
+
+#[AsResource]
+#[Delete(
+    processor: DeleteBoardGameProcessor::class,
+    read: false,
+ )]
+final class BoardGameResource implements ResourceInterface
+{
+    // [...]
+}
+```
+
+```php
+// src/BoardGameBlog/Infrastructure/Sylius/State/Processor/DeleteBoardGameProcessor.php
+
+namespace App\BoardGameBlog\Infrastructure\Sylius\State\Processor;
+
+use App\BoardGameBlog\Application\Command\DeleteBoardGameCommand;
+use App\BoardGameBlog\Domain\ValueObject\BoardGameId;
+use App\BoardGameBlog\Infrastructure\Sylius\Resource\BoardGameResource;
+use App\Shared\Application\Command\CommandBusInterface;
+use Sylius\Resource\Context\Context;
+use Sylius\Resource\Context\Option\RequestOption;
+use Sylius\Resource\Metadata\Operation;
+use Sylius\Resource\State\ProcessorInterface;
+use Webmozart\Assert\Assert;
+
+final class DeleteBoardGameProcessor implements ProcessorInterface
+{
+    public function __construct(
+        private CommandBusInterface $commandBus,
+    ) {
+    }
+
+    public function process(mixed $data, Operation $operation, Context $context): mixed
+    {
+        Assert::isInstanceOf($data, BoardGameResource::class);
+        
+        // Data is not provided in this case, so you will need to get it from the HTTP request
+        $id = $context->get(RequestOption::class)?->attributes->get('id') ?? null;
+        Assert::notNull($id);
+
+        $this->commandBus->dispatch(new DeleteBoardGameCommand(new BoardGameId($id)));
+
+        return null;
+    }
+}
+```
+
 **[Go back to the documentation's index](index.md)**
 
 **[> Next chapter: Processors](processors.md)**

src/Bundle/AbstractResourceBundle.php

@@ -85,8 +85,6 @@ protected function getDoctrineMappingDirectory(): string
 
     /**
      * Return the entity namespace.
-     *
-     * @return string
      */
     protected function getModelNamespace(): ?string
     {

src/Bundle/EventListener/ORMTranslatableListener.php

@@ -14,8 +14,8 @@
 namespace Sylius\Bundle\ResourceBundle\EventListener;
 
 use Doctrine\Common\EventSubscriber;
-use Doctrine\ORM\Event\LifecycleEventArgs;
 use Doctrine\ORM\Event\LoadClassMetadataEventArgs;
+use Doctrine\ORM\Event\PostLoadEventArgs;
 use Doctrine\ORM\Events;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Mapping\ClassMetadataInfo;
@@ -72,7 +72,7 @@ public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs): void
         }
     }
 
-    public function postLoad(LifecycleEventArgs $args): void
+    public function postLoad(PostLoadEventArgs $args): void
     {
         $entity = $args->getObject();
 

src/Bundle/Form/EventSubscriber/AddCodeFormSubscriber.php

@@ -26,9 +26,6 @@ final class AddCodeFormSubscriber implements EventSubscriberInterface
 
     private array $options;
 
-    /**
-     * @param string $type
-     */
     public function __construct(?string $type = null, array $options = [])
     {
         $this->type = $type ?? TextType::class;

src/Bundle/Resources/config/services/integrations/translation.xml

@@ -30,8 +30,7 @@
         <service id="sylius.translation.translatable_listener.doctrine.orm" class="Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener">
             <argument type="service" id="sylius.resource_registry" />
             <argument type="service" id="sylius.translatable_entity_locale_assigner" />
-            <tag name="doctrine.event_listener" connection="default" event="loadClassMetadata" priority="99" />
-            <tag name="doctrine.event_listener" connection="default" event="postLoad" priority="99" />
+            <tag name="doctrine.event_subscriber" connection="default" priority="99" />
         </service>
         <service id="Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener" alias="sylius.translation.translatable_listener.doctrine.orm" />
 

src/Component/src/Doctrine/Persistence/RepositoryInterface.php

@@ -18,7 +18,6 @@
 
 /**
  * @template T of ResourceInterface
- *
  * @extends ObjectRepository<T>
  */
 interface RepositoryInterface extends ObjectRepository

src/Component/src/Metadata/MetadataInterface.php

@@ -30,9 +30,6 @@ public function getPluralName(): string;
 
     public function getDriver(): string|false;
 
-    /**
-     * @return ?string
-     */
     public function getTemplatesNamespace(): ?string;
 
     /**