Skip to content

Commit 914f99c

Browse files
authored
bug #883 Fix form parameter bags accesing in request handler (NoResponseMate)
This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #876, followup of #507 | License | MIT Keeping the way we access the parameters bag the same way it's done in the base class. Refs: - https://github.com/symfony/form/blob/5.4/Extension/HttpFoundation/HttpFoundationRequestHandler.php - https://github.com/symfony/form/blob/6.4/Extension/HttpFoundation/HttpFoundationRequestHandler.php Commits ------- cedee23 Fix form parameter bags accesing in request handler
2 parents 3f2cde3 + cedee23 commit 914f99c

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

src/Bundle/Form/Extension/HttpFoundation/HttpFoundationRequestHandler.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function handleRequest(FormInterface $form, mixed $request = null): void
6060
return;
6161
}
6262

63-
$data = $request->query->all($name);
63+
$data = $request->query->all()[$name];
6464
}
6565
} else {
6666
// Mark the form with an error if the uploaded size was too large
@@ -93,12 +93,7 @@ public function handleRequest(FormInterface $form, mixed $request = null): void
9393
/** @psalm-var array|null $default */
9494
$default = $form->getConfig()->getCompound() ? [] : null;
9595

96-
if ($request->request->has($name)) {
97-
$params = $request->request->all($name);
98-
} else {
99-
$params = $default;
100-
}
101-
96+
$params = $request->request->all()[$name] ?? $default;
10297
$files = $request->files->get($name, $default);
10398
} else {
10499
// Don't submit the form if it is not present in the request

0 commit comments

Comments
 (0)