Skip to content

Commit d419191

Browse files
authored
refactor #896 Move attributes operation route factory into sylius resource namespace (loic425)
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no (introduced in 1.11) | Deprecations? | no | Related tickets | | License | MIT Commits ------- fcd6097 Move attributes operation route factory into sylius resource namespace
2 parents 9f50383 + fcd6097 commit d419191

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

src/Bundle/Resources/config/services/routing.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,12 @@
9898
<service id="sylius.routing.factory.route_attributes" class="Sylius\Bundle\ResourceBundle\Routing\RouteAttributesFactory" public="false" />
9999
<service id="Sylius\Bundle\ResourceBundle\Routing\RouteAttributesFactoryInterface" alias="sylius.routing.factory.route_attributes" />
100100

101-
<service id="sylius.routing.factory.attributes_operation_route" class="Sylius\Bundle\ResourceBundle\Routing\AttributesOperationRouteFactory" public="false">
101+
<service id="sylius.routing.factory.attributes_operation_route" class="Sylius\Resource\Symfony\Routing\Factory\AttributesOperationRouteFactory" public="false">
102102
<argument type="service" id="sylius.resource_registry" />
103103
<argument type="service" id="sylius.routing.factory.operation_route" />
104104
<argument type="service" id="sylius.resource_metadata_collection.factory.attributes" />
105105
</service>
106-
<service id="Sylius\Bundle\ResourceBundle\Routing\AttributesOperationRouteFactoryInterface" alias="sylius.routing.factory.attributes_operation_route" />
106+
<service id="Sylius\Resource\Symfony\Routing\Factory\AttributesOperationRouteFactoryInterface" alias="sylius.routing.factory.attributes_operation_route" />
107107

108108
<service id="sylius.routing.factory.operation_route" class="Sylius\Resource\Symfony\Routing\Factory\OperationRouteFactory" public="false">
109109
<argument type="service" id="sylius.routing.factory.operation_route_path_factory" />

src/Bundle/Routing/RoutesAttributesLoader.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
namespace Sylius\Bundle\ResourceBundle\Routing;
1515

1616
use Sylius\Resource\Reflection\ClassReflection;
17+
use Sylius\Resource\Symfony\Routing\Factory\AttributesOperationRouteFactoryInterface;
1718
use Symfony\Bundle\FrameworkBundle\Routing\RouteLoaderInterface;
1819
use Symfony\Component\Routing\RouteCollection;
1920

src/Bundle/spec/Routing/RoutesAttributesLoaderSpec.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515

1616
use PhpSpec\ObjectBehavior;
1717
use Prophecy\Argument;
18-
use Sylius\Bundle\ResourceBundle\Routing\AttributesOperationRouteFactoryInterface;
1918
use Sylius\Bundle\ResourceBundle\Routing\RouteAttributesFactoryInterface;
2019
use Sylius\Bundle\ResourceBundle\Routing\RoutesAttributesLoader;
20+
use Sylius\Resource\Symfony\Routing\Factory\AttributesOperationRouteFactoryInterface;
2121
use Symfony\Bundle\FrameworkBundle\Routing\RouteLoaderInterface;
2222
use Symfony\Component\Routing\RouteCollection;
2323

src/Bundle/spec/Routing/AttributesOperationRouteFactorySpec.php renamed to src/Component/spec/Symfony/Routing/Factory/AttributesOperationRouteFactorySpec.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@
1111

1212
declare(strict_types=1);
1313

14-
namespace spec\Sylius\Bundle\ResourceBundle\Routing;
14+
namespace spec\Sylius\Resource\Symfony\Routing\Factory;
1515

1616
use PhpSpec\ObjectBehavior;
1717
use Prophecy\Argument;
18-
use Sylius\Bundle\ResourceBundle\Routing\AttributesOperationRouteFactory;
1918
use Sylius\Component\Resource\Tests\Dummy\DummyResourceWithOperations;
2019
use Sylius\Resource\Metadata\Create;
2120
use Sylius\Resource\Metadata\Index;
@@ -24,6 +23,7 @@
2423
use Sylius\Resource\Metadata\Resource\Factory\AttributesResourceMetadataCollectionFactory;
2524
use Sylius\Resource\Metadata\Show;
2625
use Sylius\Resource\Metadata\Update;
26+
use Sylius\Resource\Symfony\Routing\Factory\AttributesOperationRouteFactory;
2727
use Sylius\Resource\Symfony\Routing\Factory\OperationRouteFactory;
2828
use Sylius\Resource\Symfony\Routing\Factory\RouteName\OperationRouteNameFactory;
2929
use Sylius\Resource\Symfony\Routing\Factory\RoutePath\OperationRoutePathFactoryInterface;

src/Bundle/Routing/AttributesOperationRouteFactory.php renamed to src/Component/src/Symfony/Routing/Factory/AttributesOperationRouteFactory.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,14 @@
1111

1212
declare(strict_types=1);
1313

14-
namespace Sylius\Bundle\ResourceBundle\Routing;
14+
namespace Sylius\Resource\Symfony\Routing\Factory;
1515

1616
use Sylius\Resource\Metadata\HttpOperation;
1717
use Sylius\Resource\Metadata\MetadataInterface;
1818
use Sylius\Resource\Metadata\Operations;
1919
use Sylius\Resource\Metadata\RegistryInterface;
2020
use Sylius\Resource\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
2121
use Sylius\Resource\Metadata\ResourceMetadata;
22-
use Sylius\Resource\Symfony\Routing\Factory\OperationRouteFactoryInterface;
2322
use Symfony\Component\Routing\Route;
2423
use Symfony\Component\Routing\RouteCollection;
2524
use Webmozart\Assert\Assert;

src/Bundle/Routing/AttributesOperationRouteFactoryInterface.php renamed to src/Component/src/Symfony/Routing/Factory/AttributesOperationRouteFactoryInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
declare(strict_types=1);
1313

14-
namespace Sylius\Bundle\ResourceBundle\Routing;
14+
namespace Sylius\Resource\Symfony\Routing\Factory;
1515

1616
use Symfony\Component\Routing\RouteCollection;
1717

0 commit comments

Comments
 (0)