From f8461b2fc59ca24c285270f5752c397839bb54b9 Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Thu, 19 Sep 2024 11:04:37 +0200 Subject: [PATCH 1/3] update readme --- jmx-scraper/README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/jmx-scraper/README.md b/jmx-scraper/README.md index a041414e6..d6293b787 100644 --- a/jmx-scraper/README.md +++ b/jmx-scraper/README.md @@ -1,6 +1,8 @@ # JMX Metric Scraper This utility provides a way to query JMX metrics and export them to an OTLP endpoint. -The JMX MBeans and their metrics mapping is defined in YAML. +The JMX MBeans and their metrics mapping is defined in YAML and is reusing implementation from +[jmx-metrics instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/jmx-metrics). -This is currently experimental, but the end goal is to provide an alternative to the [jmx-metrics](../jmx-metrics/README.md) utility. +This is currently a work-in-progress component not ready to be used in production. +The end goal is to provide an alternative to the [JMX Gatherer](../jmx-metrics/README.md) utility. From 71a5749c885ab4d7a75aea55f506c8787de8c63d Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Thu, 19 Sep 2024 11:04:45 +0200 Subject: [PATCH 2/3] disable publication until ready --- jmx-scraper/build.gradle.kts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/jmx-scraper/build.gradle.kts b/jmx-scraper/build.gradle.kts index 1ffe28de6..2c86b84e7 100644 --- a/jmx-scraper/build.gradle.kts +++ b/jmx-scraper/build.gradle.kts @@ -3,7 +3,9 @@ plugins { id("com.github.johnrengelman.shadow") id("otel.java-conventions") - id("otel.publish-conventions") + + // publishing disabled until component is ready to be used + // id("otel.publish-conventions") } description = "JMX metrics scraper" From 317fcdec67fc254d9e8631e59e8c2de46e9fabd8 Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Thu, 19 Sep 2024 11:04:57 +0200 Subject: [PATCH 3/3] remove test dependency from runtime --- jmx-scraper/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jmx-scraper/build.gradle.kts b/jmx-scraper/build.gradle.kts index 2c86b84e7..d034f1183 100644 --- a/jmx-scraper/build.gradle.kts +++ b/jmx-scraper/build.gradle.kts @@ -18,11 +18,11 @@ dependencies { implementation("io.opentelemetry:opentelemetry-sdk") implementation("io.opentelemetry:opentelemetry-sdk-metrics") implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure") - implementation("io.opentelemetry:opentelemetry-sdk-testing") implementation("io.opentelemetry.instrumentation:opentelemetry-jmx-metrics") testImplementation("org.junit-pioneer:junit-pioneer") + testImplementation("io.opentelemetry:opentelemetry-sdk-testing") } testing {