feat: assume :terminates_locally for most loops

[MilesCranmer]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (b705e46) to head (a77d24f).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   96.63%   96.19%   -0.45%     
==========================================
  Files          30       30              
  Lines        2589     2577      -12     
==========================================
- Hits         2502     2479      -23     
- Misses         87       98      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Benchmark Results (Julia v1)

Time benchmarks

	master	a77d24f...	master / a77d24f...
eval/ComplexF32/evaluation	7.17 ± 0.57 ms	7.22 ± 0.55 ms	0.993 ± 0.11
eval/ComplexF64/evaluation	10.6 ± 0.83 ms	10.7 ± 0.85 ms	0.993 ± 0.11
eval/Float32/derivative	11.4 ± 0.65 ms	11.1 ± 0.64 ms	1.03 ± 0.083
eval/Float32/derivative_turbo	11.4 ± 0.57 ms	11 ± 0.58 ms	1.03 ± 0.075
eval/Float32/evaluation	2.74 ± 0.29 ms	2.72 ± 0.28 ms	1.01 ± 0.15
eval/Float32/evaluation_bumper	0.606 ± 0.019 ms	0.571 ± 0.021 ms	1.06 ± 0.051
eval/Float32/evaluation_turbo	0.512 ± 0.029 ms	0.508 ± 0.033 ms	1.01 ± 0.087
eval/Float32/evaluation_turbo_bumper	0.606 ± 0.017 ms	0.573 ± 0.016 ms	1.06 ± 0.041
eval/Float64/derivative	14 ± 1 ms	14.2 ± 0.88 ms	0.983 ± 0.094
eval/Float64/derivative_turbo	14.5 ± 1.1 ms	14.3 ± 0.86 ms	1.01 ± 0.096
eval/Float64/evaluation	2.94 ± 0.39 ms	2.98 ± 0.38 ms	0.988 ± 0.18
eval/Float64/evaluation_bumper	1.19 ± 0.089 ms	1.16 ± 0.084 ms	1.02 ± 0.11
eval/Float64/evaluation_turbo	0.969 ± 0.081 ms	0.977 ± 0.067 ms	0.992 ± 0.11
eval/Float64/evaluation_turbo_bumper	1.19 ± 0.088 ms	1.17 ± 0.055 ms	1.01 ± 0.088
utils/combine_operators/break_sharing	0.0415 ± 0.0019 ms	0.0411 ± 0.002 ms	1.01 ± 0.068
utils/convert/break_sharing	27.9 ± 3.7 μs	28.7 ± 3.5 μs	0.972 ± 0.18
utils/convert/preserve_sharing	0.0993 ± 0.006 ms	0.102 ± 0.0056 ms	0.978 ± 0.08
utils/copy/break_sharing	28.2 ± 3.3 μs	28.7 ± 3.4 μs	0.981 ± 0.16
utils/copy/preserve_sharing	0.0994 ± 0.0053 ms	0.101 ± 0.0085 ms	0.987 ± 0.098
utils/count_constant_nodes/break_sharing	12.8 ± 1.3 μs	13.4 ± 1.5 μs	0.956 ± 0.14
utils/count_constant_nodes/preserve_sharing	0.0846 ± 0.0038 ms	0.087 ± 0.0041 ms	0.972 ± 0.063
utils/count_depth/break_sharing	13.6 ± 1.8 μs	13.9 ± 1.4 μs	0.975 ± 0.16
utils/count_nodes/break_sharing	12.2 ± 1.3 μs	12.4 ± 1.2 μs	0.981 ± 0.14
utils/count_nodes/preserve_sharing	0.0855 ± 0.0043 ms	0.0864 ± 0.0041 ms	0.99 ± 0.068
utils/get_set_constants!/break_sharing	0.033 ± 0.0024 ms	0.0347 ± 0.0034 ms	0.951 ± 0.11
utils/get_set_constants!/preserve_sharing	0.178 ± 0.0089 ms	0.18 ± 0.0084 ms	0.991 ± 0.068
utils/get_set_constants_parametric	0.0488 ± 0.0046 ms	0.0498 ± 0.0053 ms	0.98 ± 0.14
utils/has_constants/break_sharing	7.69 ± 0.96 μs	7.57 ± 0.9 μs	1.02 ± 0.18
utils/has_operators/break_sharing	2.46 ± 0.16 μs	2.48 ± 0.15 μs	0.992 ± 0.088
utils/hash/break_sharing	23.6 ± 2.3 μs	23.8 ± 2.3 μs	0.989 ± 0.14
utils/hash/preserve_sharing	0.0975 ± 0.004 ms	0.0992 ± 0.0046 ms	0.983 ± 0.061
utils/index_constant_nodes/break_sharing	29.5 ± 3 μs	30.2 ± 3 μs	0.978 ± 0.14
utils/index_constant_nodes/preserve_sharing	0.1 ± 0.0077 ms	0.103 ± 0.0046 ms	0.976 ± 0.087
utils/is_constant/break_sharing	8.27 ± 0.95 μs	8.32 ± 1 μs	0.994 ± 0.17
utils/simplify_tree/break_sharing	25.8 ± 2.2 μs	26.2 ± 2.5 μs	0.985 ± 0.13
utils/simplify_tree/preserve_sharing	0.107 ± 0.0045 ms	0.106 ± 0.0048 ms	1.01 ± 0.063
utils/string_tree/break_sharing	0.471 ± 0.021 ms	0.458 ± 0.03 ms	1.03 ± 0.081
utils/string_tree/preserve_sharing	0.564 ± 0.018 ms	0.56 ± 0.02 ms	1.01 ± 0.049
time_to_load	0.227 ± 0.00081 s	0.228 ± 0.00069 s	0.993 ± 0.0046

Memory benchmarks

	master	a77d24f...	master / a77d24f...
eval/ComplexF32/evaluation	0.954 k allocs: 2.44 MB	0.963 k allocs: 2.46 MB	0.991
eval/ComplexF64/evaluation	0.987 k allocs: 5.03 MB	0.996 k allocs: 5.07 MB	0.991
eval/Float32/derivative	4.66 k allocs: 17.6 MB	4.66 k allocs: 17.5 MB	1
eval/Float32/derivative_turbo	4.65 k allocs: 17.5 MB	4.66 k allocs: 17.6 MB	0.997
eval/Float32/evaluation	0.966 k allocs: 1.26 MB	0.99 k allocs: 1.29 MB	0.976
eval/Float32/evaluation_bumper	0.303 k allocs: 0.393 MB	0.303 k allocs: 0.393 MB	1
eval/Float32/evaluation_turbo	0.966 k allocs: 1.26 MB	0.966 k allocs: 1.26 MB	1
eval/Float32/evaluation_turbo_bumper	0.303 k allocs: 0.393 MB	0.303 k allocs: 0.393 MB	1
eval/Float64/derivative	4.78 k allocs: 0.035 GB	4.78 k allocs: 0.035 GB	1
eval/Float64/derivative_turbo	4.81 k allocs: 0.0352 GB	4.78 k allocs: 0.0349 GB	1.01
eval/Float64/evaluation	1.01 k allocs: 2.58 MB	1.01 k allocs: 2.58 MB	1
eval/Float64/evaluation_bumper	0.303 k allocs: 0.771 MB	0.303 k allocs: 0.771 MB	1
eval/Float64/evaluation_turbo	0.993 k allocs: 2.54 MB	0.969 k allocs: 2.48 MB	1.02
eval/Float64/evaluation_turbo_bumper	0.303 k allocs: 0.771 MB	0.303 k allocs: 0.771 MB	1
utils/combine_operators/break_sharing	4 allocs: 0.953 kB	4 allocs: 0.953 kB	1
utils/convert/break_sharing	2 k allocs: 0.123 MB	2 k allocs: 0.123 MB	1
utils/convert/preserve_sharing	2.4 k allocs: 0.192 MB	2.4 k allocs: 0.192 MB	1
utils/copy/break_sharing	2 k allocs: 0.123 MB	2 k allocs: 0.123 MB	1
utils/copy/preserve_sharing	2.4 k allocs: 0.192 MB	2.4 k allocs: 0.192 MB	1
utils/count_constant_nodes/break_sharing	4 allocs: 0.953 kB	4 allocs: 0.953 kB	1
utils/count_constant_nodes/preserve_sharing	0.404 k allocs: 0.0696 MB	0.404 k allocs: 0.0696 MB	1
utils/count_depth/break_sharing	4 allocs: 0.953 kB	4 allocs: 0.953 kB	1
utils/count_nodes/break_sharing	4 allocs: 0.953 kB	4 allocs: 0.953 kB	1
utils/count_nodes/preserve_sharing	0.404 k allocs: 0.0696 MB	0.404 k allocs: 0.0696 MB	1
utils/get_set_constants!/break_sharing	0.898 k allocs: 25.2 kB	0.898 k allocs: 25.2 kB	1
utils/get_set_constants!/preserve_sharing	1.7 k allocs: 0.138 MB	1.7 k allocs: 0.138 MB	1
utils/get_set_constants_parametric	1.42 k allocs: 0.0663 MB	1.42 k allocs: 0.0663 MB	1
utils/has_constants/break_sharing	4 allocs: 0.203 kB	4 allocs: 0.203 kB	1
utils/has_operators/break_sharing	4 allocs: 0.203 kB	4 allocs: 0.203 kB	1
utils/hash/break_sharing	0.104 k allocs: 2.52 kB	0.104 k allocs: 2.52 kB	1
utils/hash/preserve_sharing	0.504 k allocs: 0.0711 MB	0.504 k allocs: 0.0711 MB	1
utils/index_constant_nodes/break_sharing	2.1 k allocs: 0.094 MB	2.1 k allocs: 0.094 MB	1
utils/index_constant_nodes/preserve_sharing	2.5 k allocs: 0.163 MB	2.5 k allocs: 0.163 MB	1
utils/is_constant/break_sharing	4 allocs: 0.203 kB	4 allocs: 0.203 kB	1
utils/simplify_tree/break_sharing	4 allocs: 0.953 kB	4 allocs: 0.953 kB	1
utils/simplify_tree/preserve_sharing	0.404 k allocs: 0.0696 MB	0.404 k allocs: 0.0696 MB	1
utils/string_tree/break_sharing	11.8 k allocs: 1.04 MB	11.8 k allocs: 1.04 MB	1
utils/string_tree/preserve_sharing	12.2 k allocs: 1.11 MB	12.2 k allocs: 1.11 MB	1
time_to_load	0.159 k allocs: 11.2 kB	0.159 k allocs: 11.2 kB	1

[MilesCranmer]

Wow there's like no performance difference...